Fightwarn - macos llvm - noreturn by jimklimov · Pull Request #879 · networkupstools/nut

jimklimov · 2020-11-17T23:18:05Z

Follows up from #823 and #844 to address warnings from clang10 on MacOS builds: pre-declare attributes for routines that exit() so the compiler can optimize for no return path handling.

jimklimov · 2020-11-20T11:05:57Z

Error reports from clang were cut short by their reporting limits, some more "appeared" in view after the cleanup. PR would grow :)

…h same-named func argument

… upsd.c and main.c) with func argument "progname"

…ribute__((...)) use-cases of interest to NUT

…warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

… warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

…er warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

…ifndef HAVE___ATTRIBUTE__NORETURN" to avoid warnings

…er warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

…t is aborted)

…t after fatalx()

…after fatalx()

…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

…c "break;" after returns in conditionals

… compiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

…a legacy off-chance that fatalx() might not exit the program

…andle a legacy off-chance that fatalx() might not exit the program

…e handle a legacy off-chance that fatalx() might not exit the program

lgtm-com · 2020-11-20T18:22:22Z

This pull request fixes 1 alert when merging 7ce0e11 into 709800c - view on LGTM.com

fixed alerts:

1 for Local variable hides global variable

jimklimov added the ready / code review Author (and CI) consider the PR worthy of human rewievers' time label Nov 17, 2020

jimklimov added 28 commits November 20, 2020 18:51

common/parseconf.c: annotate pconf_fatal() with noreturn attr

b62bb16

drivers/main.c: annotate forceshutdown() with noreturn attr

82a0bd7

drivers/dstate.c: annotate sock_fail() with noreturn attr

dfd4e5a

drivers/serial.c: annotate ser_open_error() with noreturn attr

51793a8

drivers/liebert.c: annotate upsdrv_shutdown() with noreturn attr

f2cf292

drivers/skel.c: annotate upsdrv_shutdown() with noreturn attr

626fd10

drivers/clone.c: annotate upsdrv_shutdown() with noreturn attr

5189f3e

drivers/ivtscd.c: annotate upsdrv_shutdown() with noreturn attr

8ceb6f3

drivers/apcupsd-ups.c: annotate upsdrv_shutdown() with noreturn attr

8101881

drivers/nutdrv_qx.c: annotate upsdrv_shutdown() with noreturn attr

dfe756b

drivers/macosx-ups.c: annotate upsdrv_shutdown() with noreturn attr

836b8b7

drivers/upsdrvctl.c: annotate help() with noreturn attr

89cccde

clients/upslog.c: annotate help() with noreturn attr

7d22fa8

clients/upsimage.c: annotate drawimage() with noreturn attr

9e7c274

clients/upsset.c: annotate several routines with noreturn attrs

f82d661

clients/upsmon.c: help(): do not shadow global varname "progname" wit…

53af05e

…h same-named func argument

clients/upsmon.c: annotate several routines with noreturn attrs

aa95630

drivers/dummy-ups.c: annotate upsdrv_shutdown() with noreturn attr

9318c37

drivers/blazer.c: annotate upsdrv_shutdown() with noreturn attr

7768913

drivers/riello_ser.c: annotate upsdrv_shutdown() with noreturn attr

9bcad3f

drivers/bcmxcp_usb.c: fix indenting whitespace

1f7a63e

drivers/bcmxcp_usb.c: annotate nutusb_open_error() with noreturn attr

ba1fd29

drivers/nut-ipmipsu.c: annotate upsdrv_shutdown() with noreturn attr

0ff3265

server/upsd.c: help(): do not shadow global varnames "progname" (from…

618fa4c

… upsd.c and main.c) with func argument "progname"

server/upsd.c: annotate help() with noreturn attr

f2aa96c

configure.ac: introduce AX_C___ATTRIBUTE__ from gnu.org

2b9880f

m4/ax_c___attribute__.m4: extend to declare support for certain __att…

b24e3a8

…ribute__((...)) use-cases of interest to NUT

include/attribute.h: align with AX_C___ATTRIBUTE__ autoconf macro

2ca8f0a

jimklimov added 20 commits November 20, 2020 18:51

server/upsd.c: wrap unreachable exit() added due to earlier compiler …

f38768c

…warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

clients/upsc.c: wrap unreachable exit() added due to earlier compiler…

0a7bcf7

… warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

clients/upscmd.c: wrap unreachable exit() added due to earlier compil…

1ee2274

…er warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

clients/upslog.c: wrap unreachable switch()-break after help() with "…

1669b95

…ifndef HAVE___ATTRIBUTE__NORETURN" to avoid warnings

clients/upsmon.c: wrap unreachable switch()-break after help() with "…

a9c4caa

…ifndef HAVE___ATTRIBUTE__NORETURN" to avoid warnings

clients/upsmon.c: wrap unreachable exit() added due to earlier compil…

b66e175

…er warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

GitIgnore temporary dirs made by configure script (remain around if i…

14465d8

…t is aborted)

drivers/dummy-ups.c: a switch() default needs no break, especially no…

f2815a8

…t after fatalx()

drivers/metasys.c: a switch() default needs no break, especially not …

de38573

…after fatalx()

drivers/usbhid-ups.c: wrap unreachable exit() added due to earlier co…

14d3b25

…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

drivers/tripplite_usb.c: control_outlet(): do not warn about syntacti…

1003f8b

…c "break;" after returns in conditionals

drivers/tripplite_usb.c: wrap unreachable exit() added due to earlier…

3f3957f

… compiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

drivers/blazer_usb.c: wrap unreachable exit() added due to earlier co…

5b835cc

…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

drivers/riello_usb.c: wrap unreachable exit() added due to earlier co…

d2ab8e1

…mpiler warnings with "ifndef HAVE___ATTRIBUTE__NORETURN" to avoid opposite warnings now

drivers/upsdrvctl.c: a switch() default needs no break

2ac8d6a

server/upsd.c: a switch() default needs no break

5a69161

server/upsd.c: a move "help" switch() handling to default case

73045a5

drivers/libusb.c: do not warn about unreachable code where we handle …

b4ab135

…a legacy off-chance that fatalx() might not exit the program

drivers/richcomm_usb.c: do not warn about unreachable code where we h…

441b7d1

…andle a legacy off-chance that fatalx() might not exit the program

drivers/nutdrv_atcl_usb.c: do not warn about unreachable code where w…

7ce0e11

…e handle a legacy off-chance that fatalx() might not exit the program

jimklimov force-pushed the fightwarn-macos-llvm-noreturn branch from 46383fb to 7ce0e11 Compare November 20, 2020 18:05

jimklimov merged commit 4db45f7 into networkupstools:master Nov 21, 2020

jimklimov mentioned this pull request Nov 22, 2020

fightwarn - fix diags pragmas to use our configured-support macros for cleaner fencing (unreachable code) #898

Merged

jimklimov mentioned this pull request Jan 12, 2023

Add .editorconfig and revise doc files with style #1808

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fightwarn - macos llvm - noreturn#879

Fightwarn - macos llvm - noreturn#879
jimklimov merged 48 commits intonetworkupstools:masterfrom
jimklimov:fightwarn-macos-llvm-noreturn

jimklimov commented Nov 17, 2020

Uh oh!

jimklimov commented Nov 20, 2020

Uh oh!

lgtm-com Bot commented Nov 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jimklimov commented Nov 17, 2020

Uh oh!

jimklimov commented Nov 20, 2020

Uh oh!

lgtm-com Bot commented Nov 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant