nutclient.cpp: match a copy constructor with a copy assignment…#880
Merged
jimklimov merged 4 commits intonetworkupstools:masterfrom Nov 25, 2020
Merged
Conversation
jimklimov
added
ready / code review
|
This pull request fixes 3 alerts when merging 3738a7f6129bb5a134776704dcb2f8555b77ae28 into 27e1507 - view on LGTM.com fixed alerts:
|
Member
Author
|
At least in UPDATE: Others addressed in #902 |
|
This pull request fixes 3 alerts when merging f4c414a5af14015d9b2e4cd25bb330bd2d32d454 into 58fff85 - view on LGTM.com fixed alerts:
|
…or (Device, Variable, Command classes)
…pying by assignment and by constructor
jimklimov
force-pushed
the
fightwarn-lgtm-com-cxx-constructors-copiers
branch
from
f4c414a to
fd10631
Compare
|
This pull request fixes 3 alerts when merging fd10631 into 58fff85 - view on LGTM.com fixed alerts:
|
jimklimov
removed
the
need testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…operator (Device, Variable, Command classes)
Fixes part of LGTM.com suggestions per #823 (comment)
https://lgtm.com/rules/2165180572/