fightwarn - avoid variable-length arrays, their support became optional after C99#910
Merged
jimklimov merged 8 commits intonetworkupstools:masterfrom Nov 29, 2020
Merged
Conversation
…ptional after C99
…e optional after C99
…me optional after C99
…ptional after C99
|
This pull request introduces 1 alert when merging f0167e6 into 1d9d22a - view on LGTM.com new alerts:
|
jimklimov
added
need testing
|
This pull request introduces 1 alert when merging 836a4fb into e3a5544 - view on LGTM.com new alerts:
|
clepple
approved these changes
Nov 28, 2020
Member
clepple
left a comment
clepple
left a comment
There was a problem hiding this comment.
Changes seem reasonable, but as with a lot of the other changes, we'll want to mention in the release notes (or better yet, on the lists beforehand) that testing is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up from #823 / #844 efforts, this PR avoids initializing variable-length arrays in the code. In most cases it was changed to dynamic
xmalloc/free-before-returnhandling. A couple of subsequent fixes forrhino.calso got here, which depend on these changes.In the
solis.cdriver it was just replaced by the macro which (in header) initializes the unmodifiable (right?) typed variable: