Add support for Delta UPS Amplon R Series#987
Add support for Delta UPS Amplon R Series#987jimklimov merged 2 commits intonetworkupstools:masterfrom
Conversation
4728920 to
6a448f6
Compare
|
Looks quite solid to me, thanks! Before merging, I'd rather wait a few days for comments from other community members though. |
jimklimov
left a comment
There was a problem hiding this comment.
Is this a corporate or volunteer contribution? In the former case, you may want to add an entry to docs/acknowledgements.txt
This is volunteer contribution. |
aquette
left a comment
There was a problem hiding this comment.
Lgtm
Still, you will want to list it in the manpage, driver.list and to provide a data dump for the DDL. Thanks for your contribution
|
@aquette How can I provide a data dump? |
|
Thanks for the PR and sorry about the delay for your question. The NUT DDL is documented and displayed at https://networkupstools.org/ddl/index.html for example; basically is is a report of Maint. UPDATE: DDL entry posted as networkupstools/nut-ddl#11 - thanks @jungeonkim |
|
Note to self: on the line above the Vendor ID macro there should be a comment with vendor name, it is used by the script which generates udev rules. Like in commit 01efa50 fixed now :) |
…orkupstools/nut#987] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This PR adds support for Delta UPS Amplon R Serise (https://www.deltapowersolutions.com/en/mcis/1kva-3kva-single-phase-ups-r-series.php)
Tested on R1K and R3K model.