Skip to content

Add support for Delta UPS Amplon R Series#987

Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom
jungeonkim:master
Apr 20, 2021
Merged

Add support for Delta UPS Amplon R Series#987
jimklimov merged 2 commits intonetworkupstools:masterfrom
jungeonkim:master

Conversation

@jungeonkim
Copy link
Copy Markdown
Contributor

@jungeonkim jungeonkim commented Mar 13, 2021

This PR adds support for Delta UPS Amplon R Serise (https://www.deltapowersolutions.com/en/mcis/1kva-3kva-single-phase-ups-r-series.php)
Tested on R1K and R3K model.

battery.capacity: 100
battery.charge: 100.0
battery.charge.low: 20
battery.charge.warning: 20
battery.runtime: 6496
battery.temperature: 31.9
battery.voltage: 54.1
battery.voltage.nominal: 48
device.mfr: DELTA
device.model: UPS202R2000B0BA
device.serial: [reduced]
device.type: ups
driver.name: usbhid-ups
driver.parameter.pollfreq: 5
driver.parameter.pollinterval: 2
driver.parameter.port: auto
driver.parameter.synchronous: no
driver.version: 2.7.4-1-gb34f2434
driver.version.data: Delta UPS HID 0.1
driver.version.internal: 0.41
input.frequency: 59.9
input.sensitivity: normal
input.source: normal
input.transfer.high: 280
input.transfer.high.max: 280
input.transfer.high.min: 270
input.transfer.low: 80
input.transfer.low.max: 90
input.transfer.low.min: 80
input.voltage: 218.0
output.current: 0.0
output.frequency: 59.9
output.frequency.nominal: 60
output.voltage: 218.0
output.voltage.nominal: 220
ups.beeper.status: enabled
ups.delay.start: 0
ups.load: 8.0
ups.mfr: DELTA
ups.model: UPS202R2000B0BA
ups.power.nominal: 2000
ups.productid: 041b
ups.realpower: 155.0
ups.serial [reduced]
ups.start.auto: yes
ups.status: OL
ups.timer.reboot: 0
ups.timer.shutdown: -1
ups.timer.start: 0
ups.type: online
ups.vendorid: 05dd

@jungeonkim jungeonkim force-pushed the master branch 5 times, most recently from 4728920 to 6a448f6 Compare March 13, 2021 21:41
@jimklimov
Copy link
Copy Markdown
Member

Looks quite solid to me, thanks!

Before merging, I'd rather wait a few days for comments from other community members though.

@jimklimov jimklimov added feature ready / code review Author (and CI) consider the PR worthy of human rewievers' time labels Mar 13, 2021
Copy link
Copy Markdown
Member

@jimklimov jimklimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a corporate or volunteer contribution? In the former case, you may want to add an entry to docs/acknowledgements.txt

@jungeonkim
Copy link
Copy Markdown
Contributor Author

Is this a corporate or volunteer contribution? In the former case, you may want to add an entry to docs/acknowledgements.txt

This is volunteer contribution.

Copy link
Copy Markdown
Member

@aquette aquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Still, you will want to list it in the manpage, driver.list and to provide a data dump for the DDL. Thanks for your contribution

@jungeonkim
Copy link
Copy Markdown
Contributor Author

@aquette How can I provide a data dump?

@jimklimov
Copy link
Copy Markdown
Member

jimklimov commented Apr 20, 2021

Thanks for the PR and sorry about the delay for your question. The NUT DDL is documented and displayed at https://networkupstools.org/ddl/index.html for example; basically is is a report of upsc ups@localhost and similar tools to save a snapshot of what fields are recognized by this driver (version) for this device, and sample reasonable values for them. In practice the dump can be generated by ./tools/nut-ddl-dump.sh in the codebase and reported in NUT issues or mailing list so we would (eventually) post it to the DDL, or even directly PRed to https://github.com/networkupstools/nut-ddl

Maint. UPDATE: DDL entry posted as networkupstools/nut-ddl#11 - thanks @jungeonkim

@jimklimov jimklimov merged commit ffec5bb into networkupstools:master Apr 20, 2021
@jimklimov
Copy link
Copy Markdown
Member

Note to self: on the line above the Vendor ID macro there should be a comment with vendor name, it is used by the script which generates udev rules. Like in commit 01efa50 fixed now :)

@jimklimov jimklimov added this to the 2.8.0 milestone Oct 7, 2024
jimklimov added a commit to networkupstools/nut-ddl that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DDL enhancement feature HCL ready / code review Author (and CI) consider the PR worthy of human rewievers' time USB

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants