Add password for SSH, AWS and GDrive config #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZiminski
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JoeZiminski
force-pushed
the
add_password_to_rclone_config_for_aws_gdrive
branch
from
53a5a05 to
274fe29
Compare
JoeZiminski
commented
Oct 7, 2025
JoeZiminski
commented
Oct 7, 2025
JoeZiminski
force-pushed
the
add_password_to_rclone_config_for_aws_gdrive
branch
3 times, most recently
from
44af5de to
5c21724
Compare
JoeZiminski
force-pushed
the
add_password_to_rclone_config_for_aws_gdrive
branch
from
350ac89 to
0c2c1b2
Compare
cs7-shrey
reviewed
Dec 17, 2025
Collaborator
cs7-shrey
left a comment
cs7-shrey
left a comment
There was a problem hiding this comment.
Hey @JoeZiminski, this is really well thought out. You have covered all the cases here very elegantly. I have dropped a few minor suggestions here and there, otherwise the implementation is logically and structurally very sound.
Co-authored-by: Shrey Singh <96627769+cs7-shrey@users.noreply.github.com>
Co-authored-by: Shrey Singh <96627769+cs7-shrey@users.noreply.github.com>
….com:neuroinformatics-unit/datashuttle into add_password_to_rclone_config_for_aws_gdrive
…d encryption set up, and some small tidy ups.
Co-authored-by: Shrey Singh <96627769+cs7-shrey@users.noreply.github.com>
….com:neuroinformatics-unit/datashuttle into add_password_to_rclone_config_for_aws_gdrive
cs7-shrey
reviewed
Dec 20, 2025
Collaborator
cs7-shrey
left a comment
cs7-shrey
left a comment
There was a problem hiding this comment.
LGTM. Just one small change.
|
|
||
| self.interface = interface | ||
| self.no_browser_stage: None | str = "show_command_to_generate_code" | ||
| self.no_browser_stage: None | str = "pending" |
Collaborator
There was a problem hiding this comment.
I meant that this variable could be called something like self.client_secret_stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to encrypt the RClone config file containing SSH, AWS or GDrive connection information (e.g. private key, passwords, access tokens). The main changes are:
.conffiles (previously, the RClone default to store everything in RClone'srclone.confwas used. This is still kept forlocal_filesystemfor backwards compatibility.This required quite a lot of refactoring to the setup connection functions (API and TUI) as well as the internal calls to rclone. Now, these calls are wrapped in some functionality that handles unencrypting the rclone config if required.
Tests and documentation have been updated.
This implementation is okay but there is still room for improvement. However, as this PR is pretty big and we just need to get this out, these are reversed for the future (#636).