Skip to content

Conversation

@radditude
Copy link

@radditude radditude commented Aug 27, 2020

This is a fix for a small bit of unexpected behavior when using Papers::ManifestUpdater.new.update! to automatically update the manifest during test runs.

Currently, if you configure a custom manifest file using

Papers.configure do |config|
  config.manifest_file = "config/my_awesome_manifest.yml"
end

calling Papers::ManifestUpdater.new.update! does not update that configured manifest file. Instead, it tries to update config/papers_manifest.yml.

This is easy enough to work around by passing the path like so:

Papers::ManifestUpdater.new("config/my_awesome_manifest.yml").update!

But that's kind of a bummer. It would be nice if the updater used the configured manifest file if one exists - I thought so, anyway, and I hope you agree! 😄

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Previously, calling Papers::ManifestUpdater.new.update! updated
config/papers_manifest.yml by default. This change allows the
updater to use the manifest file that has been globally configured
if it exists.
@radditude radditude force-pushed the radditude/allow-updater-to-use-configured-manifest branch from c05b695 to 1858c40 Compare August 27, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants