Change rwf file isidora #713
Conversation
|
There are other places in the code where this file is used, maybe it would be safer to replace it everywhere, checking that the tests that use it don't rely on the specific content of the file. What do you think about it? |
|
Seems reasonable. The initial commits just replaced it where the test accessed the MC info. I'll do another set of commits removing it completely. Should I remove the file from the repository too? |
|
Yeah, I think we can remove it, once it is not used anymore. |
|
For instance, to me |
paolafer
left a comment
paolafer
left a comment
There was a problem hiding this comment.
This PR eliminates a test file that had wrong MC true information. The tests that used it have been modified to use a different file with similar content and the file has been removed. All the tests succeed now, so I approve this PR.
andLaing
force-pushed
the
change_RWF_file_isidora
branch
from
536169c to
ea20f84
Compare
electrons_40keV_z250_RWF.h5 had badly written MC info. Tests now use electrons_40keV_z25_RWF.h5 which has no mistake in the MC info. Change files_in in all configs which used the faulty file to use the same replacement file Remove electrons_40keV_z250_RWF.h5 from fixture electron_RWF_file
andLaing
force-pushed
the
change_RWF_file_isidora
branch
from
ea20f84 to
9d97a04
Compare
next-exp#713 [author: andLaing] Removes the use of the file electrons_40keV_z250_RWF.h5 in the isidora tests and in the commandline tests for isidora and irene. This file was found to have badly written MC info in PR next-exp#693 [reviewer: paolafer] This PR eliminates a test file that had wrong MC true information. The tests that used it have been modified to use a different file with similar content and the file has been removed. All the tests succeed now, so I approve this PR.
3 participants
Removes the use of the file electrons_40keV_z250_RWF.h5 in
the isidora tests and in the commandline tests for isidora
and irene.
This file was found to have badly written MC info in PR #693