fix(ts): revert session callback type changes#7136
Merged
balazsorban44 merged 1 commit intonextauthjs:v4from Apr 3, 2023
juliusmarminge:patch-1
Merged
fix(ts): revert session callback type changes#7136balazsorban44 merged 1 commit intonextauthjs:v4from juliusmarminge:patch-1
session callback type changes#7136balazsorban44 merged 1 commit intonextauthjs:v4from
juliusmarminge:patch-1
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@juliusmarminge is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
See #7132 (comment), happy to discuss on that issue if we should revert or keep it, not sure. 🙏 |
balazsorban44
approved these changes
Apr 3, 2023
Member
balazsorban44
left a comment
There was a problem hiding this comment.
Thank you! Based on the discussion, this is fair!
session callback type changes
|
I found the main problem here. When you hover over user on the right side one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7132
Fixes t3-oss/create-t3-app#1328
Seems like #7056 changed this type which breaks module augmentation.
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: INSERT_ISSUE_LINK_HERE
📌 Resources