fix: return fallback if value cannot be parsed #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
============================================
+ Coverage 86.36% 100.00% +13.63%
============================================
Files 1 1
Lines 22 26 +4
Branches 5 7 +2
============================================
+ Hits 19 26 +7
+ Misses 3 0 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If there is a fallback we should handle this error more gracefully. We report it in the console, but return the fallback if provided. Otherwise we just throw as before. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/return-fallback-error
branch
from
3fc566d to
234ecbf
Compare
Antreesy
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a fallback we should handle this error more gracefully. We report it in the console, but return the fallback if provided. Otherwise we just throw as before.