refactor(gettext): Drop node-gettext dependency and use our translation logic
#851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
type: dependencies
skjnldsv
approved these changes
Feb 4, 2025
ShGKme
approved these changes
Feb 5, 2025
susnux
commented
Feb 5, 2025
…tion logic Instead of relying on a (insecure!) dependency we can reuse our already implemented logic for translations. So we reuse the app translation logic also for the gettext based translations. 1. Allow to pass the translation bundle to our translation functions 2. Convert gettext JSON format to our Nextcloud translation format in the GettextBuilder. 3. Wrap the translation function within out gettext wrapper class For the enduser this should not change anything (except that we do not have the debug messages `node-gettext` provided). Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Grigorii K. Shartsev <grigorii.shartsev@nextcloud.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/drop-node-gettext
branch
from
7fd1ec5 to
5e82a6e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on a (insecure!) dependency we can reuse our already implemented logic for translations.
So we reuse the app translation logic also for the gettext based translations.
For the enduser this should not change anything (except that we do not have the debug messages
node-gettextprovided).