Skip to content

fix(#195): Handle zero-byte downloads correctly. #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i2h3 merged 1 commit into from
Oct 15, 2025
Merged

fix(#195): Handle zero-byte downloads correctly. #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Sources/NextcloudKit/NextcloudKit+Download.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,11 @@ public extension NextcloudKit {
options.queue.async { taskHandler(task) }
} .downloadProgress { progress in
options.queue.async { progressHandler(progress) }
} .responseData(queue: self.nkCommonInstance.backgroundQueue) { response in
switch response.result {
case .failure(let error):
} .response(queue: self.nkCommonInstance.backgroundQueue) { response in
if let error = response.error {
let resultError = NKError(error: error, afResponse: response, responseData: nil)
options.queue.async { completionHandler(account, nil, nil, 0, response.response?.allHeaderFields, error, resultError) }
case .success:
} else {
var date: Date?
var etag: String?
var length: Int64 = 0
Expand Down
Loading