Skip to content

[stable29] Remove requiring PNG for iOS #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
Sep 23, 2024
Merged

[stable29] Remove requiring PNG for iOS #1795

artonge merged 1 commit into from
Sep 23, 2024

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Sep 20, 2024

Backport of PR #1793

@backportbot backportbot bot requested review from artonge and mpivchev September 20, 2024 10:28
@backportbot backportbot bot added this to the Nextcloud 29.0.7 milestone Sep 20, 2024
@mpivchev @backportbot
Change flag
2573165 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@backportbot backportbot bot force-pushed the backport/1793/stable29 branch from 5afad35 to 2573165 Compare September 20, 2024 10:42
@cypress
Copy link

cypress bot commented Sep 20, 2024 •
edited
Loading

Activity    Run #2001

Run Properties:  status check failed Failed #2001  •  git commit 04fbdc770f: [stable29] Remove requiring PNG for iOS
Project Activity
Branch Review backport/1793/stable29
Run status status check failed Failed #2001
Run duration 06m 34s
Commit git commit 04fbdc770f: [stable29] Remove requiring PNG for iOS
Committer backportbot[bot]
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 8
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has rename activity Test Replay Screenshots
Check activity listing in the sidebar > Has comment activity Test Replay Screenshots
Flakiness  sidebar.cy.ts • 2 flaky tests • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has favorite activity Test Replay Screenshots
Check activity listing in the sidebar > Has tag activity Test Replay Screenshots
Flakiness  settings.cy.ts • 1 flaky test • Run E2E

View Output

Test Artifacts
Check that user's settings survive a reload > Form survive a reload Test Replay Screenshots

@artonge artonge enabled auto-merge September 20, 2024 10:49
@artonge artonge disabled auto-merge September 23, 2024 09:09
@artonge artonge merged commit 3c40d81 into stable29 Sep 23, 2024
@artonge artonge deleted the backport/1793/stable29 branch September 23, 2024 09:43
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@mpivchev mpivchev Awaiting requested review from mpivchev

Assignees

@mpivchev mpivchev

Labels

3. to review php

Projects

None yet

Milestone

Nextcloud 29.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @mpivchev