ignore unhandled rich objects #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
AndyScherzinger
added a commit
that referenced
this pull request
Jul 4, 2018
Backport of #153: ignore unhandled rich objects
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
force-pushed
the
handleActivityErrors
branch
from
3737b97 to
68b159c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to nextcloud/activity#277, it can happen that we cannot parse an activity correctly. In these cases we try now to show as many infos as possible, setting the unhandled cases to "".
If there is now a problematic activity, it should show at least all other ones correctly. Prior to this, it showed no activity at all.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me