Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 6, 2018

Needed for nextcloud/android#3121
Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypeMasterPR
Warnings
Errors

FindBugs (new)

Warning TypeNumber
Bad practice Warnings11
Correctness Warnings42
Internationalization Warnings5
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings28
Dodgy code Warnings84
Total199

FindBugs (master)

Warning TypeNumber
Bad practice Warnings11
Correctness Warnings42
Internationalization Warnings5
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings28
Dodgy code Warnings83
Total198

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Dec 6, 2018

👍 looks good to me

Approved with PullApprove

@AndyScherzinger AndyScherzinger added this to the NC lib 1.3.0 milestone Dec 6, 2018
@AndyScherzinger AndyScherzinger merged commit b64ed37 into master Dec 6, 2018
@AndyScherzinger AndyScherzinger deleted the getNote branch December 6, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants