Skip to content

[stable-1.6] Defensive check for Log_OC arguments for null #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 1 commit into from
Oct 2, 2019
Merged

[stable-1.6] Defensive check for Log_OC arguments for null #341

tobiasKaminsky merged 1 commit into from
Oct 2, 2019

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 2, 2019

backport of #338

@ezaquarii
Defensive check for Log_OC arguments for null
539d6e9 
Log.d does not handle null, causing NPE thrown from
native logger implementation. This defensive check
ensures that legacy clients don't crash the system.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the NC Android lib 1.6.0 milestone Oct 2, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 2, 2019
Merged
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Oct 2, 2019

Lint

Typestable-1.6PR
Warnings00
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings81
Total185

SpotBugs (stable-1.6)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings81
Total185

@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (stable-1.6@b740e76). Click here to learn what that means.
The diff coverage is 23.07%.

@@              Coverage Diff              @@
##             stable-1.6     #341   +/-   ##
=============================================
  Coverage              ?   25.11%           
=============================================
  Files                 ?      120           
  Lines                 ?     5275           
  Branches              ?      722           
=============================================
  Hits                  ?     1325           
  Misses                ?     3787           
  Partials              ?      163
Impacted Files Coverage Δ
.../com/owncloud/android/lib/common/utils/Log_OC.java 14.86% <23.07%> (ø)

@tobiasKaminsky tobiasKaminsky merged commit 42e7edd into stable-1.6 Oct 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/338/stable-1.6 branch October 2, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@ezaquarii ezaquarii Awaiting requested review from ezaquarii

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

NC Android lib 1.6.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nextcloud-android-bot @tobiasKaminsky @ezaquarii