Add RichWorkspaces support #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasKaminsky
force-pushed
the
directEditing
branch
5 times, most recently
from
fba5598 to
04cb1c1
Compare
tobiasKaminsky
force-pushed
the
directEditing
branch
2 times, most recently
from
b3ae955 to
6a639ea
Compare
tobiasKaminsky
force-pushed
the
richWorkspace
branch
from
e6f5c3f to
21869b5
Compare
tobiasKaminsky
force-pushed
the
directEditing
branch
from
ff291a9 to
1c603f3
Compare
tobiasKaminsky
force-pushed
the
richWorkspace
branch
from
0f40c49 to
edcb24a
Compare
tobiasKaminsky
force-pushed
the
richWorkspace
branch
2 times, most recently
from
3d8dbd4 to
f9922c3
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
richWorkspace
branch
from
f9922c3 to
367ed98
Compare
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1361 |
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
========================================
Coverage ? 34.3%
========================================
Files ? 133
Lines ? 5728
Branches ? 751
========================================
Hits ? 1965
Misses ? 3487
Partials ? 276
|
|
|
||
| private String path; | ||
|
|
||
| public RichWorkspaceDirectEditingRemoteOperation(String path) { |
Member
There was a problem hiding this comment.
could be created via lombok
AndyScherzinger
previously approved these changes
Dec 18, 2019
Member
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
looks good, just one minor comment
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Collaborator
|
Complexity increasing per file
==============================
- src/androidTest/java/com/nextcloud/android/lib/richWorkspace/RichWorkspaceDirectEditingRemoteOperationTest.java 1
- src/main/java/com/nextcloud/android/lib/richWorkspace/RichWorkspaceDirectEditingRemoteOperation.java 4
Clones added
============
- src/main/java/com/nextcloud/android/lib/richWorkspace/RichWorkspaceDirectEditingRemoteOperation.java 1
See the complete overview on Codacy |
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #358
Signed-off-by: tobiasKaminsky tobias@kaminsky.me