Activity: preview object now has filename #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasKaminsky
force-pushed
the
activityAPIchange
branch
from
f74b596 to
dc1268a
Compare
AndyScherzinger
previously approved these changes
May 11, 2021
Member
Sorry I was not aware that fullbackwards compatible changes which just add additional fields would break anything. |
Member
Author
I guess this heavily depends on the way one writes the parser. |
Member
Author
|
When will the new activity version be out in the wild? |
Member
|
Seems like it was backported to 21.0.2 which is coming this or next week iirc |
made parser more robust Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
activityAPIchange
branch
from
dc1268a to
c9d5aa7
Compare
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
- Coverage 40.63% 40.62% -0.01%
==========================================
Files 151 151
Lines 6202 6208 +6
Branches 804 804
==========================================
+ Hits 2520 2522 +2
- Misses 3303 3307 +4
Partials 379 379
|
Contributor
|
Can this be backported to stable-2.6? |
Member
Author
|
/backport to stable-2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made parser more robust
Introduced in nextcloud/activity@38a31e5#diff-76b5a357391276b282a516f54f48ef3c207f46d8192dc58c208d5183d38415f8
@nickvergessen do we really want to change api this silently?
Signed-off-by: tobiasKaminsky tobias@kaminsky.me