Confirmation dialog before removing an account

[AndyScherzinger]

Review from the Google Play store. User wished to have a confirmation dialog before an account is removed.
If I remember correctly we had this discussion at some point and decided not to. But, yes delete is a tricky one. Any input on this @jancborchardt ?

TASK: Show an undo toast after removing an account.

[jancborchardt]

As usual, we should offer undo here. :) It’s similar as a confirmation dialog, with the exception that confirmation dialogs are often mindlessly clicked away. Undo, where the action is directly visible (account gone) but actually only carried out in the interface, is much more error-friendly.

[AndyScherzinger]

I also though about adding an undo action here. Will have to check how to implement such a thing because this might be a delete & recreate, or a hide from list and delete in case undo hasn't been clicked whatever is technically possible.

Thanks for the feedback! :)

[jancborchardt]

or a hide from list and delete in case undo hasn't been clicked whatever is technically possible.

This is how undo generally works – just lying by removing it from the interface, and then actually deleting it when no undo has been clicked or the next action is performed.

[tobiasKaminsky]

In contributing.md is said that we should use label "accepted" for issues and 1...5 only for PRs.
I also suggest to write a summary in the first post if a conclusion is made.
(I will demonstrate it on this issue).

[przybylski]

the undo is problematic on a lot of technical levels.

• If we cheat to delete account how long should we postpone until we really delete it?
• If user closes app immediately after "deleting" account we won't be able to respond to that and account will exists.
• Removing may fail if we quietly ignore it, account will exist after "deletion".
• Toaster doesn't provide a way to get feedback when it is dismissed, but even if it did, app might be closed by then making dismiss notification null pointer vulnerable

If user won't read warning dialog than it isn't our fault.

[jancborchardt]

• If we cheat to delete account how long should we postpone until we really delete it?

What’s the default for that on Android, like for deleting pictures in Gallery? 5 seconds?

• If user closes app immediately after "deleting" account we won't be able to respond to that and account will exists.

Isn’t there an exit-app hook?

• Removing may fail if we quietly ignore it, account will exist after "deletion".

Sure, but that’s exactly the same with a confirmation dialog. Warning needs to be shown either way when the deletion fails. Undo does not mean ignoring an error, but actually the opposite: Only requiring people to take action when there is something wrong.

• Toaster doesn't provide a way to get feedback when it is dismissed, but even if it did, app might be closed by then making dismiss notification null pointer vulnerable

Isn’t there a way to work around this? Or using snackbar?

If user won't read warning dialog than it isn't our fault.

Of course it is. It’s a design issue.

[przybylski]

Isn’t there an exit-app hook?

Yes there is but it isn't guaranteed that all procedures will run uniterrupted

Isn’t there a way to work around this? Or using snackbar?

Yes, snackbar supports onDismiss notification, but I don't know how it will behave when app will be closed.

---

Generally I would rather not insert "undo" button for account deletion, this operation is significant enough that user should be sure that he/she is 100% sure about the consequences.
If we will pretend that account was deleted when in fact it wasn't than the app and system will be in weird state when system sees something else than app.

But even if I get outvoted on that I think for now it is crucial enough to at least put a confirmation dialog there, which I already did in my pull request.