Add "upload existing"-option to autoupload

[saibotk]

Hello guys,

I wondered if there is any reason, why the auto upload is just uploading new files, which from my perspective does not fulfill a good UX. As an example, i recently showed NC to my parents and the first expected behaviour was, that it would automaticially upload the whole folder and new files.
So that is, why i'd like to suggest to either add an info to the screen, stating that only new files will be uploaded, or add a "upload existing"-checkbox in the autoupload UI.

I think this could improve the UX on this significantly, because uploading a folder manually is not as easy as the autoupload interface, which seems to be more intuitive.

Just a suggestion, id like to hear your opinions on this,
Keep up the good work 👍

Greetings

[harrisonland]

I'd agree with this, tbh. It's one of the things that struck me as a bit odd when I first set up Nextcloud..

[AndyScherzinger]

Hi @saibotk, hi @harrisonland - This is on the roadmap, see #285 but nobody had the time to implement it just yet and being a open source project contributions are always welcome ❤️

[harrisonland]

Thanks for response, @AndyScherzinger . Frankly, I wish I had more time to learn some programming and be able to contribute, but my wife would kill me! ;-)

Be assured that your efforts are really appreciated.

[saibotk]

Thank you, I wish i had more time and less concurrent projects too, but i'll see...

[YounoYouno]

This would be the only feature i'd ever wish for in the NC app, thanks for getting this out there.

[javaisbetterthanpython]

@AndyScherzinger

What determines the prioritization of these feature requests? Seems like this is a high requested feature.

I looked at how this would be implemented, and my guess is basically, in the function to add a new directory to the auto-upload watchlist, these two steps would simply need to be taken:

• Perform a directory listing of files in the target directory
• Iterate through the list and add a new job for each existing file

I'm thinking this could be added either to SyncedFoldersActivity.class or actually even earlier in the MainApp.java between 538 and 539, just after dialog.dismiss() before context.startActivity(folderSyncIntent).

Would this approach make sense or am I missing something?

[AndyScherzinger]

@javaisbetterthanpython yes something like that while @mario is the expert on this matter and I am sure if you would be happy to take on this task he'll sure be around to support you. Triggering this initial part within the SyncedFolderActivity seems fine while I can't say if it shouldn't be done within the Job itself directly since large, existing folders might be an issue if you do this within the activity...

As for prioritization that is hard to tell, @tobiasKaminsky and @mario both work for Nextcloud as a company so their priorities are a mix of community feedback and customer feedback. I am on the othr and do this in my spare time besides my day job so for me priority is rather looking at what I can get done within this limited timebox.

[javaisbetterthanpython]

Thanks for the reply.

@mario do you have any thoughts about the best approach to implement this capability? Does what I outlined seem reasonable, or should we take a different approach?

I looked at the code more today and am thinking that a "FilesSyncJob" needs to be created for existing files in the directory when it is first added to the "auto-upload" list in "SyncedFoldersActivity"? Is that right?

[AndyScherzinger]

@tobiasKaminsky due to time constraints and work load, can you help out @javaisbetterthanpython? :)

[tobiasKaminsky]

Is "upload existing" meant to be a one time action? E.g. a button in the settings of the synced folder?

Overall the main problem is if there are already images in the target folder, to distinguish if they need to re-upload or not:

• We could simply compare them by name, but this will not work on devices which name their image img_001, img_002.
• we could simply upload everything, leading to have duplicated files, which is a bad UX

An idea, which is not perfect, is to use some kind of hash:

• first check file name
• if file name already exists, check hash
• if hash is the same do nothing, else upload, but append (2)

[AndyScherzinger]

Imho it should be a one time action and could be triggered whenever an auto upload is configured for a folder the very first time (can be detected since we don't have a database record yet) and then simply push all existing files to the server.
We could of course add a button so users can manually trigger such a thing at a later point in time while this will make it a bit more complicated since we then definitely need the file checks you described @tobiasKaminsky .

[javaisbetterthanpython]

Agree with @AndyScherzinger - Also, I think the complexity to manually trigger this at-will would be unnecessary.

From my perspective, just getting a one time action to trigger whenever a new auto-upload is configured for a folder for the first time would be sufficient.

@tobiasKaminsky Does it make sense to include that one-time action in the updateToAutoUpload() function in MainApp.java? Or is it better off in the SyncedFoldersActivity.java?

I've only spent a couple hours reading the source and am starting to get an idea of how things work, but any thoughts would be appreciated.

[AndyScherzinger]

Afaik it should be fine to include it in the SyncedFoldersActivity for a one-time action. If I remember correctly anything else is about restarts so if the auto upload queue gets filled with the existing files then we are all set.

[tobiasKaminsky]

SyncedFoldersActivity is good.
We still need some sort of file check, as it might that in the target folder on server are already files named the same.
(on fresh installations chances are not that high, but on re-installations of the app this might happen)