share link with password not fit to password rule ('Updating share failed')

[mr-bolle]

Steps to reproduce

1. password rule have to be set (for example 10 characters) on nextcloud
2. in the android app share a file or folder
3. enable "share link"
4. set a password (ex. Test123456)
5. v3.3.0: this is a common used password - android notice ony 'Updating share failed'
   v201809: this is a common used password - android notice "Password is among the 1,000,000 most common ones. Please make it unique" and later ony 'Updating share failed'

Youtube Screencast
00:00 - 00:10 seconds: Nextcloud DEV (with Server v14.0.1)
00:11 - 00:21 seconds: Nextcloud v3.3.0 (with Server v13.0.6)

Expected behaviour

If the set password doesn't fit to the password rules, it have to be shown the right error message.

Actual behaviour

Only universal error message 'Updating share failed' shown

Server configuration detail

Operating system: Linux 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64

Webserver: Apache/2.4.25 (Debian) (apache2handler)

Database: mysql 10.3.9

PHP version:

7.2.9
Modules loaded: Core, date, libxml, openssl, pcre, sqlite3, zlib, ctype, curl, dom, fileinfo, filter, ftp, hash, iconv, json, mbstring, SPL, PDO, session, posix, Reflection, standard, SimpleXML, pdo_sqlite, Phar, tokenizer, xml, xmlreader, xmlwriter, mysqlnd, apache2handler, apcu, exif, gd, intl, ldap, memcached, pcntl, pdo_mysql, pdo_pgsql, redis, sodium, zip, Zend OPcache

Nextcloud version: 13.0.6 - 13.0.6.1 and 14.0.1

Updated from an older Nextcloud/ownCloud or fresh install: fresh [docker compose]

Where did you install Nextcloud from: https://github.com/nextcloud/docker/tree/master/.examples/docker-compose/with-nginx-proxy/mariadb-cron-redis/apache

Signing status

Array
(
)

List of activated apps

Enabled:
 - activity: 2.6.1
 - audioplayer: 2.4.1
 - bookmarks: 0.12.2
 - bruteforcesettings: 1.1.0
 - calendar: 1.6.1
 - comments: 1.3.0
 - contacts: 2.1.5
 - dav: 1.4.7
 - deck: 0.4.1
 - drawio: 0.9.1
 - federatedfilesharing: 1.3.1
 - federation: 1.3.0
 - files: 1.8.0
 - files_external: 1.4.1
 - files_markdown: 2.0.4
 - files_pdfviewer: 1.2.1
 - files_sharing: 1.5.0
 - files_texteditor: 2.5.1
 - files_trashbin: 1.3.0
 - files_versions: 1.6.0
 - files_videoplayer: 1.2.0
 - firstrunwizard: 2.2.1
 - gallery: 18.0.0
 - issuetemplate: 0.4.0
 - keeweb: 0.4.0-mod
 - logreader: 2.0.0
 - lookup_server_connector: 1.1.0
 - nextcloud_announcements: 1.2.0
 - notifications: 2.1.2
 - oauth2: 1.1.1
 - ownbackup: 18.8.1
 - password_policy: 1.3.0
 - provisioning_api: 1.3.0
 - ransomware_protection: 1.1.2
 - richdocuments: 2.0.13
 - sharebymail: 1.3.0
 - spreed: 3.2.6
 - survey_client: 1.1.0
 - systemtags: 1.3.0
 - tasks: 0.9.7
 - theming: 1.4.5
 - twofactor_backupcodes: 1.2.3
 - twofactor_totp: 1.4.1
 - updatenotification: 1.3.0
 - workflowengine: 1.3.0
Disabled:
 - admin_audit
 - encryption
 - serverinfo
 - user_external
 - user_ldap

Configuration (config/config.php)

{
    "htaccess.RewriteBase": "\/",
    "memcache.local": "\\OC\\Memcache\\APCu",
    "apps_paths": [
        {
            "path": "\/var\/www\/html\/apps",
            "url": "\/apps",
            "writable": true
        },
        {
            "path": "\/var\/www\/html\/custom_apps",
            "url": "\/custom_apps",
            "writable": true
        }
    ],
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 6379
    },
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "nextcloud.example.com"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "overwrite.cli.url": "https:\/\/nextcloud.example.com",
    "dbtype": "mysql",
    "version": "13.0.6.1",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "theme": "",
    "loglevel": 1,
    "maintenance": false,
    "mail_smtpmode": "smtp",
    "mail_smtpauthtype": "LOGIN",
    "mail_smtpsecure": "tls",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauth": 1,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "587",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "trashbin_retention_obligation": "30, 90",
    "versions_retention_obligation": "30, 180"
}

Are you using external storage, if yes which one: local/smb

Are you using encryption:

Are you using an external user-backend, if yes which one: Webdav

Client configuration

Browser:

Operating system:

Logs

Nextcloud log Android v3.3.0 App

2018/10/10 12:53:29
LogHistoryActivity : onPause() ending

2018/10/10 12:53:29
Preferences : onStart() starting

2018/10/10 12:53:29
Preferences : onResume() starting

2018/10/10 12:53:30
LogHistoryActivity : onStop() ending

2018/10/10 12:53:30
LogHistoryActivity : onDestroy() ending

2018/10/10 12:53:31
Preferences : onPause() ending

2018/10/10 12:53:32
BaseActivity : onRestart() start

2018/10/10 12:53:32
BaseActivity : onRestart() end

2018/10/10 12:53:32
FileDisplayActivity : onStart() starting

2018/10/10 12:53:32
OwnCloudClient #3 : REQUEST GET /index.php/apps/files/api/v1/thumbnail/64/64/temp/upload%20%40Win_Sync/Nextcloud%20android/2018-10-10-12-41-40_screenRecording.mp4

2018/10/10 12:53:32
OwnCloudClient #3 : REQUEST GET /ocs/v1.php/cloud/user

2018/10/10 12:53:32
AdvancedSslSocketFactory : Creating SSL Socket with remote nextcloud.example.com:443, local null:0, params: org.apache.commons.httpclient.params.HttpConnectionParams@24dfba5

2018/10/10 12:53:32
AdvancedSslSocketFactory :  ... with connection timeout 60000 and socket timeout 60000

2018/10/10 12:53:32
Avatar : URI: https://nextcloud.example.com/index.php/avatar/Raiko/224

2018/10/10 12:53:32
OwnCloudClient #3 : REQUEST GET /index.php/avatar/Raiko/224

2018/10/10 12:53:32
ServerNameIndicator : SSLSocket implementation: com.google.android.gms.org.conscrypt.Java8FileDescriptorSocket

2018/10/10 12:53:32
AdvancedSslSocketFactory : Creating SSL Socket with remote nextcloud.example.com:443, local null:0, params: org.apache.commons.httpclient.params.HttpConnectionParams@36fa2ea

2018/10/10 12:53:32
ServerNameIndicator : SNI done, hostname: nextcloud.example.com

2018/10/10 12:53:32
AdvancedSslSocketFactory :  ... with connection timeout 60000 and socket timeout 60000

2018/10/10 12:53:32
ServerNameIndicator : SNI done, hostname: nextcloud.example.com

2018/10/10 12:53:32
FileDisplayActivity : Initializing Fragments in onAccountChanged..

2018/10/10 12:53:32
FileDisplayActivity : onResume() start

2018/10/10 12:53:32
FileDisplayActivity : onResume() starting

2018/10/10 12:53:32
com.owncloud.android.utils.glide.HttpStreamFetcher : Cleanup

2018/10/10 12:53:32
ExternalLinks : links disabled

2018/10/10 12:53:32
FileDisplayActivity : onResume() end

2018/10/10 12:53:32
OwnCloudClient #3 : REQUEST GET /status.php

2018/10/10 12:53:32
UpdateOCVersionOperation : Got new OC version 13.0.6.1

2018/10/10 12:53:32
UpdateOCVersionOperation : Check for update of Nextcloud server version at https://nextcloud.example.com/remote.php/webdav: Operation finished with HTTP status code -1 (success)

2018/10/10 12:53:32
OwnCloudClient #3 : REQUEST GET /ocs/v1.php/cloud/capabilities

2018/10/10 12:53:32
Preferences : onStop() ending

2018/10/10 12:53:32
Preferences : onDestroy() ending

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : Successful response: {"ocs":{"meta":{"status":"ok","statuscode":100,"message":"OK","totalitems":"","itemsperpage":""},"data":{"version":{"major":13,"minor":0,"micro":6,"string":"13.0.6","edition":""},"capabilities":{"core":{"pollinterval":60,"webdav-root":"remote.php\/webdav"},"bruteforce":{"delay":0},"activity":{"apiv2":["filters","filters-api","previews","rich-strings"]},"dav":{"chunking":"1.0"},"files_sharing":{"api_enabled":true,"public":{"enabled":true,"password":{"enforced":false},"expire_date":{"enabled":false},"send_mail":false,"upload":true,"upload_files_drop":true},"resharing":true,"user":{"send_mail":false,"expire_date":{"enabled":true}},"group_sharing":true,"group":{"enabled":true,"expire_date":{"enabled":true}},"federation":{"outgoing":true,"incoming":true,"expire_date":{"enabled":true}},"sharebymail":{"enabled":true,"upload_files_drop":{"enabled":true},"password":{"enabled":true},"expire_date":{"enabled":true}}},"notifications":{"ocs-endpoints":["list","get","delete","icons","rich-strings"],"push":["devices"]},"password_policy":{"minLength":10,"enforceNonCommonPassword":true,"enforceNumericCharacters":false,"enforceSpecialCharacters":false,"enforceUpperLowerCase":true},"spreed":{"features":["audio","video","chat-v2","guest-signaling","empty-group-room","guest-display-names","multi-room-users"]},"theming":{"name":"Nextcloud","url":"https:\/\/nextcloud.com","slogan":"a safe home for all your data","color":"#0082c9","color-text":"#ffffff","color-element":"#0082c9","logo":"https:\/\/nextcloud.example.com\/apps\/theming\/logo?v=14","background":"https:\/\/nextcloud.example.com\/apps\/theming\/loginbackground?v=14","background-plain":false,"background-default":false},"files":{"bigfilechunking":true,"blacklisted_files":[".htaccess"],"undelete":true,"versioning":true}}}}}

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : *** Added version

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : *** Added core

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : *** Added files_sharing

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : *** Added files

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : *** Added theming

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : *** Added notifications

2018/10/10 12:53:32
GetRemoteCapabilitiesOperation : *** Get Capabilities completed 

2018/10/10 12:53:32
OwnCloudClient #3 : REQUEST GET /ocs/v1.php/cloud/user

2018/10/10 12:53:33
RefreshFolderOperation : Got display name: com.owncloud.android.lib.common.UserInfo@b783561

2018/10/10 12:53:33
RefreshFolderOperation : Checking changes in Raiko@nextcloud.example.com/

2018/10/10 12:53:33
OwnCloudClient #3 : REQUEST PROPFIND /remote.php/webdav/

2018/10/10 12:53:33
RefreshFolderOperation : Checked Raiko@nextcloud.example.com/ : changed

2018/10/10 12:53:33
OwnCloudClient #3 : REQUEST PROPFIND /remote.php/webdav/

2018/10/10 12:53:33
ReadRemoteFolderOperation : Synchronized /: Operation finished with HTTP status code 207 (success)

2018/10/10 12:53:33
RefreshFolderOperation : Synchronizing Raiko@nextcloud.example.com/

2018/10/10 12:53:33
RefreshFolderOperation : Remote folder / changed - starting update of local data 

2018/10/10 12:53:33
FileDataStorageManager : Saving folder / with 24 children and 0 files to remove

2018/10/10 12:53:33
FileDataStorageManager : Sending 25 operations to FileContentProvider

2018/10/10 12:53:33
FileContentProvider : applying batch in provider com.owncloud.android.providers.FileContentProvider@cb06f31 (temporary: false)

2018/10/10 12:53:33
FileContentProvider : applied batch in provider com.owncloud.android.providers.FileContentProvider@cb06f31

2018/10/10 12:53:33
RefreshFolderOperation : Send broadcast com.owncloud.android.operations.RefreshFolderOperation.EVENT_SINGLE_FOLDER_CONTENTS_SYNCED

2018/10/10 12:53:33
OwnCloudClient #3 : REQUEST GET /ocs/v2.php/apps/files_sharing/api/v1/shares

2018/10/10 12:53:33
FileDisplayActivity : Received broadcast com.owncloud.android.operations.RefreshFolderOperation.EVENT_SINGLE_FOLDER_CONTENTS_SYNCED

2018/10/10 12:53:33
FileDisplayActivity : Setting progress visibility to true

2018/10/10 12:53:33
GetRemoteSharesForFileOperation : Got 4 shares

2018/10/10 12:53:33
FileDataStorageManager : Sending 28 operations to FileContentProvider

2018/10/10 12:53:33
FileContentProvider : applying batch in provider com.owncloud.android.providers.FileContentProvider@cb06f31 (temporary: false)

2018/10/10 12:53:33
FileContentProvider : applied batch in provider com.owncloud.android.providers.FileContentProvider@cb06f31

2018/10/10 12:53:33
RefreshFolderOperation : Send broadcast com.owncloud.android.operations.RefreshFolderOperation.EVENT_SINGLE_FOLDER_SHARES_SYNCED

2018/10/10 12:53:33
FileDisplayActivity : Received broadcast com.owncloud.android.operations.RefreshFolderOperation.EVENT_SINGLE_FOLDER_SHARES_SYNCED

2018/10/10 12:53:33
FileDisplayActivity : Setting progress visibility to false

2018/10/10 12:53:36
FileDetailActivitiesFragment : BEFORE getRemoteActivitiesOperation.execute

2018/10/10 12:53:36
GetRemoteActivitiesOperation : URL: https://nextcloud.example.com/ocs/v2.php/apps/activity/api/v2/activity/filter?format=json&sort=desc&object_type=files&object_id=188

2018/10/10 12:53:36
OwnCloudClient #3 : REQUEST GET /ocs/v2.php/apps/activity/api/v2/activity/filter

2018/10/10 12:53:36
GetRemoteActivitiesOperation : Successful response: null

2018/10/10 12:53:39
FileActivity : show loading dialog

2018/10/10 12:53:39
OperationsService : Starting command with id 5

2018/10/10 12:53:39
OwnCloudClient #3 : REQUEST GET /ocs/v2.php/apps/files_sharing/api/v1/shares

2018/10/10 12:53:39
AdvancedSslSocketFactory : Creating SSL Socket with remote nextcloud.example.com:443, local null:0, params: org.apache.commons.httpclient.params.HttpConnectionParams@24dfba5

2018/10/10 12:53:39
AdvancedSslSocketFactory :  ... with connection timeout 60000 and socket timeout 60000

2018/10/10 12:53:39
ServerNameIndicator : SSLSocket implementation: com.google.android.gms.org.conscrypt.Java8FileDescriptorSocket

2018/10/10 12:53:39
ServerNameIndicator : SNI done, hostname: nextcloud.example.com

2018/10/10 12:53:39
GetRemoteSharesForFileOperation : Got 0 shares

2018/10/10 12:53:39
OwnCloudClient #3 : REQUEST POST /ocs/v2.php/apps/files_sharing/api/v1/shares

2018/10/10 12:53:39
OwnCloudClient #3 : REQUEST GET /ocs/v2.php/apps/files_sharing/api/v1/shares/115

2018/10/10 12:53:40
OperationsService : Called 1 listeners

2018/10/10 12:53:40
FileActivity : Received result of operation in FileActivity - common behaviour for all the FileActivities 

2018/10/10 12:53:40
OperationsService : Stopping after command with id 5

2018/10/10 12:53:40
FileActivity : dismiss loading dialog

2018/10/10 12:53:50
FileActivity : show loading dialog

2018/10/10 12:53:50
OperationsService : Starting command with id 6

2018/10/10 12:53:50
OwnCloudClient #3 : REQUEST PUT /ocs/v2.php/apps/files_sharing/api/v1/shares/115

2018/10/10 12:53:50
OperationsService : Called 1 listeners

2018/10/10 12:53:50
OperationsService : Stopping after command with id 6

2018/10/10 12:53:50
FileActivity : Received result of operation in FileActivity - common behaviour for all the FileActivities 

2018/10/10 12:53:50
FileActivity : dismiss loading dialog

2018/10/10 12:53:57
DrawerActivity : Unknown drawer menu item clicked: Settings

2018/10/10 12:53:57
FileDisplayActivity : onPause() start

2018/10/10 12:53:57
FileDisplayActivity : onPause() ending

2018/10/10 12:53:57
FileDisplayActivity : onPause() end

2018/10/10 12:53:57
Preferences : onCreate(Bundle) starting

2018/10/10 12:53:57
Preferences : Error retrieving user's base URI Exception : [com.owncloud.android.lib.common.OwnCloudAccount.<init>(OwnCloudAccount.java:65), com.owncloud.android.ui.activity.Preferences$18.run(Preferences.java:874), java.lang.Thread.run(Thread.java:764)]

2018/10/10 12:53:57
Preferences : onStart() starting

2018/10/10 12:53:57
Preferences : onResume() starting

2018/10/10 12:53:57
FileDisplayActivity : onSaveInstanceState() start

2018/10/10 12:53:57
FileDisplayActivity : onSaveInstanceState(Bundle) starting

2018/10/10 12:53:57
ExtendedListFragment : onSaveInstanceState()

2018/10/10 12:53:57
FileDisplayActivity : onSaveInstanceState() end

2018/10/10 12:53:57
FileDisplayActivity : onStop() ending

2018/10/10 12:53:59
Preferences : onPause() ending

2018/10/10 12:53:59
LogHistoryActivity : onCreate(Bundle) starting

2018/10/10 12:53:59
LogHistoryActivity : onStart() starting

2018/10/10 12:53:59
LogHistoryActivity : onResume() starting

2018/10/10 12:54:00
Preferences : onSaveInstanceState(Bundle) starting

2018/10/10 12:54:00
Preferences : onStop() ending

2018/10/10 12:54:01
LogHistoryActivity : onPause() ending

2018/10/10 12:54:04
ReceiveExternalFilesActivity : onCreate(Bundle) starting

2018/10/10 12:54:04
ReceiveExternalFilesActivity : onStart() starting

2018/10/10 12:54:04
ReceiveExternalFilesActivity : Populating view with content of : /temp/upload @Win_Sync/Nextcloud android/

2018/10/10 12:54:04
ReceiveExternalFilesActivity : onResume() starting

2018/10/10 12:54:04
DrawerActivity : setDrawerMenuItemChecked has been called with invalid menu-item-ID

2018/10/10 12:54:04
ExternalLinks : links disabled

2018/10/10 12:54:04
LogHistoryActivity : onSaveInstanceState(Bundle) starting

2018/10/10 12:54:04
LogHistoryActivity : onStop() ending

2018/10/10 12:54:04
FileActivity : Operations service connected

2018/10/10 12:54:05
ReceiveExternalFilesActivity : Uploading file to dir /temp/upload @Win_Sync/Nextcloud android/

2018/10/10 12:54:05
FileActivity : show loading dialog

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

[nextcloud-android-bot]

GitMate.io thinks possibly related issues are #1089 (Sharing with "password rule" enabled is not working), #2833 (Not possible to update password or remove account?), #196 (Shared link cannot be copied again), #1171 ([Share] enter password: toggle visibility of password), and #1991 (Link password policies behaviour).

[AndyScherzinger]

@tobiasKaminsky it seems we just get the exception but aren't passing the original error message back through the client to the UI. Not sure if we are just not using the error message or if it gets lost somewhere.

[tobiasKaminsky]

It seems two snackbars are shown: first the one with the correct message and then a generic one…

[tobiasKaminsky]

android/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java

Line 1756 in 6343525

public void onRemoteOperationFinish(RemoteOperation operation, RemoteOperationResult result) {

calls with super… ->

android/src/main/java/com/owncloud/android/ui/activity/FileActivity.java

Line 301 in 2e9d7ce

public void onRemoteOperationFinish(RemoteOperation operation, RemoteOperationResult result) {

and in

android/src/main/java/com/owncloud/android/ui/activity/FileActivity.java

Line 337 in 2e9d7ce

DisplayUtils.showSnackMessage(

the correct error message is shown.
But also in FileDisplayActivity, the RemoteOperationResult is handled.

added here: 42a0e28#diff-ecdca245e1aa615e4581732a6606684bR1723

I think, we can simply remove it in FDA.
(we then should have a look if other operations also generate duplicated snackbars).

[AndyScherzinger]

Solution looks fine to me while I didn't have the chance to test this yet, maybe next week

[mr-bolle]

I could help you with the tests as well, if you can share a apk I would test this tomorrow.

[tobiasKaminsky]

This seems to be solved: