Navigation drawer shows full name instead of username

Actual behaviour

When opening the navigation drawer, the displayed Cloud ID doesn't consist of <username>@<host> but instead <full name>@<host> (see screenshot). In the "Manage accounts" section, the Cloud ID is displayed correctly.

Expected behaviour

The Cloud ID should contain the username, not the full name. I remember it showing correctly, not sure what update update caused this. Maybe this is somehow related to #157 ?

Environment data

Android version: 7.1.2 (LineageOS)
Nextcloud app version: 3.7.1
Nextcloud server version: 16.0.4

Screenshots

[ezaquarii]

@AndyScherzinger

So this is the guilty party:

    public static String getAccountNameDisplayText(Context context, Account savedAccount, String accountName, String
            fallbackString) {
        try {
            return new OwnCloudAccount(savedAccount, context).getDisplayName()
                    + "@"
                    + convertIdn(accountName.substring(accountName.lastIndexOf('@') + 1), false);
        } catch (Exception e) {
            Log_OC.w(TAG, "Couldn't get display name for account, using old style");
            return fallbackString;
        }
    }

Get getName() returns string in format login@server.url. I guess this is what we want here?
I'm not sure what this "old style" concept is.

[AndyScherzinger]

I don't recall anybody changing this

Since we also display the full name, it should then obviously be the username 👍

[tobiasKaminsky]

This was changed by me as there was some reports, that this looks weird

• on ldap, e.g. 2342348972479292@server.com (as it can be any value)
• with email address as username: tobias@kaminsky.com@cloud.server.com (which is done by SimpleSignUp)

Do we need to show this information at all? Isn't this a technical detail, which is fine to shown only in user account info?
Then we could simply show the server.

[AndyScherzinger]

I think the issue is that there could be more than one account with the exact same name (first name / last name) while these accoount only differ in their username. It might be an edge case but afaik that is why we actually showed the username.

[tobiasKaminsky]

Same Display Name (can happen) on same server?
Could be…yes.
But then any ldap value / email address will look weird…

[AndyScherzinger]

Maybe the @nextcloud/designers have a nice idea how to solve this? :)

[jancborchardt]

In the desktop app we do it like this:

• Avatar on top of course
• First row shows the full name if set, user name if not
• Second row only shows the server address

How about that? Will look shorter and less technical. Yes if you have 2 exact same profiles on the same server if the same full name is set and the avatar is the same too then you can not distinguish.
It does show the "user@server" full thing on hover though, but I would say we can leave it out on mobile?