Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Apr 11, 2023

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger
Copy link
Member

before after non-root-folder
before after folder

…he line item if needed

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link

github-actions bot commented May 4, 2023

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine for me 👍

@github-actions
Copy link

github-actions bot commented May 4, 2023

@AndyScherzinger
Copy link
Member

AndyScherzinger commented May 4, 2023

@tobiasKaminsky the multiline as mentioned on the chat has been approved by Jan for the moment since we can't ellipsize

@github-actions
Copy link

github-actions bot commented May 4, 2023

Codacy

Lint

TypemasterPR
Warnings7676
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness5151
Dodgy code324323
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total496495

@github-actions
Copy link

github-actions bot commented May 4, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11515.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

@AndyScherzinger AndyScherzinger merged commit 3e1f61a into master May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the tags branch May 8, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants