Skip to content

Sort in upload files activity#124

Merged
AndyScherzinger merged 7 commits intomasterfrom
sortInUploadFilesActivity
Jul 14, 2016
Merged

Sort in upload files activity#124
AndyScherzinger merged 7 commits intomasterfrom
sortInUploadFilesActivity

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jul 13, 2016

yet another feature already implemented a while ago by @tobiasKaminsky as oc 1058

I rebased it to our latest master (not tests yet - Edit and tested now).

Add the feature to sort in the uploader, in order to avoid a long scroll when selecting the most recent files for uploading.

Putting this up for discussion if we want to integrate this. It would imho help people especially for manual photo uploads.

cc @jancborchardt @LukasReschke and @przybylski

@AndyScherzinger AndyScherzinger force-pushed the sortInUploadFilesActivity branch from 3f90a8b to 2b7c555 Compare July 14, 2016 12:43
@jancborchardt
Copy link
Member

Yes, for sure. Actually in the uploader I would say the default layout should be sort by recency, cause you are most likely to upload recently modified files.

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Jul 14, 2016

There actually isn't a default (now). The uploader is now able to change the sorting (like in the standard file list) and the sorting is shared between uploader and file list, so the last sorting chosen by the user is respected by the file list, so if you change the sorting in the uploader your local file list will adopt that sorting (and vice versa).

@jancborchardt
Copy link
Member

Ok, I guess that’s the best course of action for now. 👍

@tobiasKaminsky
Copy link
Member

LGTM

@AndyScherzinger AndyScherzinger merged commit d00893c into master Jul 14, 2016
@AndyScherzinger AndyScherzinger deleted the sortInUploadFilesActivity branch July 14, 2016 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants