Switch offline files #125
Switch offline files #125
Conversation
|
|
||
| private void fetchFavoritesToSyncFromLocalData() { | ||
| List<OCFile> children = mStorageManager.getFolderContent(mLocalFolder); | ||
| List<OCFile> children = mStorageManager.getFolderContent(mLocalFolder, true); |
There was a problem hiding this comment.
@tobiasKaminsky wasn't sure what to put in here, decided to use true, but might also be false. You might know/recall :)
There was a problem hiding this comment.
As far as I understand all files within the folder (childrens) should be fetched, therefore changing it to "false".
|
Mergable from my point of view LGTM |
|
@przybylski @tobiasKaminsky what do you think? I tested it on my device and it works (for me) |
| // MainApp.showOnlyFilesOnDevice(true); | ||
| // refreshDirectory(); | ||
| // break; | ||
| case R.id.nav_on_device: |
There was a problem hiding this comment.
show on device and show all items are mutually exclusive, so cannot be checked simultaneously. And yet, from code point of view it looks like they can. But I can be mistaken.
There was a problem hiding this comment.
Hi @przybylski they are mutually exclusive. Can you go a bit more into details why they could be checked simultaneously? The menu in general only allows one item to be in the checked state: https://github.com/nextcloud/android/blob/master/res/menu/drawer_menu.xml#L24
There was a problem hiding this comment.
This convinces me :) I haven't checked the xml file. Sorry
There was a problem hiding this comment.
No worries, I had to check the menu myself too 👍
|
👍 |
AndyScherzinger
force-pushed
the
switchOfflineFiles
branch
from
f268e2c to
2142bd5
Compare
|
@tobiasKaminsky can you have a final look for the LGTM thingy 😉 |
|
Nice, good stuff! :) We should push forward more with the offline stuff. The limited offline capability of the app was always a shortcoming – especially when you are on a train, plane or with bad mobile connection. |
|
@jancborchardt that part is still the same (at the moment), this PR basically filters out all non-offline-available files, so you only see files already on your phone so you don't accidentally download a file. |
|
Yup yup, I know – the sidebar entry. :) Good stuff 👍 |
|
@tobiasKaminsky can you check to code and if fine with you, merge? 🚀 |
|
(Btw, let’s keep the thumbs up emoji as an indicator for review. We use that since ages now. ;) And l g t m is not really understandable to many people cause it’s a really bad abbreviation.) |
|
OK! :) but for the plugin you can go for LGTM, 👍 or |
to approve (plugin enforced to MAINTAINERS responding with one of these) in order to be able to merge... 💃
|
Ah k, was just confused cause someone changed/added the +1 in my comment to LGTM (cause I didn’t write that) |
|
Yeah, that was me... 😁 |
|
LGTM |
…housekeeping here)
AndyScherzinger
force-pushed
the
switchOfflineFiles
branch
from
7a7776f to
f1e2f11
Compare
4 participants
rebased and adapted PR originally done by @tobiasKaminsky to switch between all and offline files via the drawer menu.
please review @przybylski @tobiasKaminsky
cc @LukasReschke and @jancborchardt for feature review in general even though this is an oldie PR :)