corrected icon sizes for hdpi and mdpi #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… references to OS version specific icon works anymore
Member
|
LGTM Looks good I guess. :) If sizing them down is correct |
Member
Author
|
@jancborchardt yes, the size should be 24dp according to material guidelines while we do use 24dp some icons haven't been 24dp but 36dp which leads to some "oversized" icons in cases where the OS doesn't resize on the fly and when it resizes images get slightly blurred. |
Member
|
I trust you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...like the title says, replaced all icons with wrong sizes, since on material design icons are 24dp sizes which wasn't 100% correct for some hdpi and mdpi icons, so they get resized at runtime.
Besides that, removed all unused icons.
Please review and merge @LukasReschke @przybylski @jancborchardt @tobiasKaminsky
PS: it is just icon work and sizes, so your choice to actually really look at the image diff ;)
Now all icons in all menus are shipped and no OS icon links are there anymore so it will always be nice, material style icon work 🚀