Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Aug 8, 2017

Opened against #797 to get rid of the remaining errors.

EDIT: Strange this should only show the changes... :/

AndyScherzinger and others added 30 commits August 8, 2017 09:39
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
@mario
Copy link
Contributor

mario commented Aug 8, 2017

Very strange :-/

But anyway, should be fine...

Dunno why you didn't merge this right away xD

👍

@AndyScherzinger please :)

Approved with PullApprove

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 8, 2017

👎 killed this PR by cherry picking the changes ;)

Rejected with PullApprove

@AndyScherzinger AndyScherzinger deleted the mediaStoreAutoUploadFurtherFixes branch August 8, 2017 11:24
@tobiasKaminsky
Copy link
Member Author

Hmm, I wanted to avoid getting the #797 branch way too big.
And technically these error fixes have nothing to do with the branch.
I was only basing from this branch so that we do not have any conflicts after merging...

@mario
Copy link
Contributor

mario commented Aug 8, 2017

Too late since some time ago xD

@tobiasKaminsky
Copy link
Member Author

So...If I fix the other remaining issues and maybe some warnings...all in #797? :S

@mario
Copy link
Contributor

mario commented Aug 8, 2017

If you can do it right now, yes :P Otherwise we do not wait... cc @AndyScherzinger

@AndyScherzinger
Copy link
Member

I'd say just wait for 30 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants