Skip to content

Conversation

@przybylski
Copy link
Member

No description provided.

@przybylski
Copy link
Member Author

#129

@tobiasKaminsky
Copy link
Member

Have you tested it with an owncloud app in parallel?
I think we have to modify also the package name of the class, or?

@przybylski
Copy link
Member Author

I haven't but It shouldn't be a problem, BUT ill check.

@tobiasKaminsky
Copy link
Member

I tried it, but it did not work. I had to change authorities to
com.nextcloud.android.providers.UsersAndGroupsSearchProvider

@AndyScherzinger
Copy link
Member

I've tested it with @przybylski's latest commit and it is working. 👍

@AndyScherzinger
Copy link
Member

@przybylski @tobiasKaminsky - one minor thing though which we can postpone for now. The authority changes are now using com.nextcloud.android which nicely matches the app's id except for the newly introduced document provider which is packaged in org.nextcloud. Not sure if we want to change this, but using com.nextcloud.android as a parent package for new thing seems consistent naming wise.

@AndyScherzinger
Copy link
Member

@tobiasKaminsky can you also do a final test/approval ?

@tobiasKaminsky
Copy link
Member

@AndyScherzinger regarding com.nextcloud vs. org.nextcloud we should discuss in a new issue.

@tobiasKaminsky
Copy link
Member

I have tested it with both apps installed in parallel.
It works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants