Skip to content

#145 Alternative fix for drawer navigation fix in upload activity #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 4 commits into from
Jul 24, 2016
Merged

#145 Alternative fix for drawer navigation fix in upload activity #148

tobiasKaminsky merged 4 commits into from
Jul 24, 2016

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jul 22, 2016

fix for #145 - alternative implementation approach to #146

pinging @przybylski and @tobiasKaminsky for feedback

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.2.0 milestone Jul 22, 2016
@AndyScherzinger AndyScherzinger mentioned this pull request Jul 22, 2016
Closed
@przybylski
Copy link
Member

przybylski commented Jul 22, 2016

better, one thing tho, showFiles(boolean) does set parameter in MainApp, maybe move that to super implementation (DrawerActivity) ?

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Jul 22, 2016 •
edited
Loading

@przybylski DONE, see 58f8650 - I moved it to FileActivity though, so the Drawer implementation can still declare the method abstract to force others to implement it and FileActivity is a super class of the using classes for Upload and Display so I found that to be a nice place to put it. :) Fine with you? 😃 👍

@przybylski
Copy link
Member

przybylski commented Jul 22, 2016 •
edited by tobiasKaminsky
Loading

👍
LGTM

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jul 23, 2016

👍
Then we should release a RC2 within the next few days?

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Jul 23, 2016

Yes we should. Can you guys take care of it?

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jul 24, 2016

LGTM
The only remaining "problem" is that you do not get back to the folder you had opened before switching to "uploads".
But this is a separate issue.

@tobiasKaminsky tobiasKaminsky merged commit c405859 into master Jul 24, 2016
@AndyScherzinger AndyScherzinger deleted the 145_no_go_back_alternative branch July 27, 2016 15:27
@axel3i-ENSMM axel3i-ENSMM mentioned this pull request Jul 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

Nextcloud App 1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyScherzinger @przybylski @tobiasKaminsky