Skip to content

Screenshots with fastlane screengrab#1603

Merged
tobiasKaminsky merged 11 commits intomasterfrom
screenshots
Jan 5, 2018
Merged

Screenshots with fastlane screengrab#1603
tobiasKaminsky merged 11 commits intomasterfrom
screenshots

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 28, 2017

Is used to generate screenshots in 44 languages on three devices.
Can be merged later.

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 2.1.0 milestone Sep 28, 2017
mario
mario previously requested changes Oct 2, 2017
View reviewed changes
src/debug/AndroidManifest.xml Outdated

<application
android:testOnly="false"/>
</manifest> No newline at end of file
Copy link
Contributor

@mario mario Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line please.

fastlane/Fastfile Outdated

platform :android do
before_all do
# ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
Copy link
Contributor

@mario mario Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to remove all redundant/not used stuff.

@mario
Copy link
Contributor

mario commented Nov 24, 2017

@tobiasKaminsky rebase and fix things I mentioned pls :)

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Dec 13, 2017

As of wish by @jancborchardt (#1081 (comment)) I will include mocked devices.

@nextcloud nextcloud deleted a comment Dec 13, 2017
@nextcloud nextcloud deleted a comment Dec 13, 2017
@nextcloud nextcloud deleted a comment Dec 13, 2017
@nextcloud nextcloud deleted a comment Dec 13, 2017
@nextcloud nextcloud deleted a comment Dec 13, 2017
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Dec 15, 2017

Here you can find them for phone & tablet:
https://nextcloud.kaminsky.me/index.php/s/Hsp5M4Lq9yiy9zz

jancborchardt
jancborchardt approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT 😍 @tobiasKaminsky

@tobiasKaminsky tobiasKaminsky force-pushed the screenshots branch 2 times, most recently from 5ac9601 to 84f537d Compare December 15, 2017 13:41
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Dec 15, 2017

@mario @AndyScherzinger please review
And then, once we have enough translations, I will upload the screenshots to fdroid / gplay.

AndyScherzinger
AndyScherzinger reviewed Dec 15, 2017
View reviewed changes
fastlane/Screengrabfile Outdated
locales ['en-US', 'de-DE', 'en-GB', 'fr-FR', 'it-IT', 'pt-BR', 'pt-PT', 'sv-SE', 'sq-AL', 'sq-MK', 'iw-IL', 'ar-AR', 'bg-BG', 'da-DK', 'fi-FI', 'gl-ES', 'hu-HU', 'tr-TR', 'uk-UK', 'vi-VI', 'ro-RO', 'ru-RU', 'sr-SR', 'pl-PL', 'el-GR', 'ko-KR', 'nl-NL', 'ja-JP', 'no-NO', 'eu-ES', 'lt-LT', 'es-ES', 'es-419', 'zh-HK', 'zk-CN', 'is-IS', 'sr-SR', 'id-ID', 'cs-CZ', 'sl-SL', 'fa-FA' ]

# clear all previously generated screenshots in your local output directory before creating new ones
clear_previous_screenshots true No newline at end of file
Copy link
Member

@AndyScherzinger AndyScherzinger Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this file also get a new line?

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Dec 16, 2017 •
edited
Loading

👍 fine by me :)

Approved with PullApprove

@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 21, 2017
Closed
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Dec 21, 2017

@mario ping :-)

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Jan 2, 2018

@mario happy new year and please review :-)

@mario
Copy link
Contributor

mario commented Jan 4, 2018 •
edited by AndyScherzinger
Loading

I will need a bribe for this xD

👍

Approved with PullApprove

@tobiasKaminsky tobiasKaminsky merged commit 6c8993e into master Jan 5, 2018
@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Jan 5, 2018

Merging with only one approval as @AndyScherzinger is on vacation.

@tobiasKaminsky tobiasKaminsky deleted the screenshots branch January 5, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

+1 more reviewer

@mario mario mario left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud App 3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky @mario @AndyScherzinger @jancborchardt