-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New media detection #2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New media detection #2406
Conversation
|
This is now ready for review folks! @AndyScherzinger @tobiasKaminsky |
|
Ummm so I checked lint report, but don't see what new warnings are? |
|
You have to compare it with master.html which is in the same directory. |
|
Looks ok now @tobiasKaminsky. Please test and review. |
5d4a3c1 to
5dc41c7
Compare
|
I tested it installing OpenCamera and that didn't completely work for me.
The configuration is active while the pictures taken after don't get detected / uploaded. |
|
@AndyScherzinger could you look into NCContentObserverJob and see what syncedFolderProvider.countEnabledSyncedFolders() returns there? |
|
@AndyScherzinger @tobiasKaminsky fixed for real this time. Please rebase and test. Thanks!!! |
05e1cab to
bbb4f4b
Compare
|
Can't test right now (time-wise) but did the rebase :) |
|
Anyone tested this? |
23c6858 to
2b02e40
Compare
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
…ationCompat constructor
5066a73 to
47217e7
Compare
Lint
FindBugs (new)
FindBugs (master)
|
|
Oh this is exciting! Thanks folks! |
Fixes #1447
Detects new media folder and notifies users about it.