Skip to content

Conversation

@mario
Copy link
Contributor

@mario mario commented Mar 27, 2018

Fixes #1447

Detects new media folder and notifies users about it.

@mario
Copy link
Contributor Author

mario commented Mar 27, 2018

This is now ready for review folks! @AndyScherzinger @tobiasKaminsky

@nextcloud nextcloud deleted a comment Mar 27, 2018
@nextcloud nextcloud deleted a comment Mar 27, 2018
@nextcloud nextcloud deleted a comment Mar 27, 2018
@mario
Copy link
Contributor Author

mario commented Mar 27, 2018

Ummm so I checked lint report, but don't see what new warnings are?

@tobiasKaminsky
Copy link
Member

You have to compare it with master.html which is in the same directory.
There is a lint tool to use current master as baseline, which then should only show the difference, but this does not work, so we have to compare it manually :/

@nextcloud nextcloud deleted a comment Mar 29, 2018
@nextcloud nextcloud deleted a comment Mar 29, 2018
@nextcloud nextcloud deleted a comment Mar 29, 2018
@mario
Copy link
Contributor Author

mario commented Mar 29, 2018

Looks ok now @tobiasKaminsky. Please test and review.

@nextcloud nextcloud deleted a comment Apr 3, 2018
@AndyScherzinger
Copy link
Member

I tested it installing OpenCamera and that didn't completely work for me.

  • Works: Detection of new Folder 👍
  • Failed: Directly configuring the new folder via the notification :(

The configuration is active while the pictures taken after don't get detected / uploaded.

@mario
Copy link
Contributor Author

mario commented Apr 4, 2018

@AndyScherzinger could you look into NCContentObserverJob and see what syncedFolderProvider.countEnabledSyncedFolders() returns there?

@mario
Copy link
Contributor Author

mario commented Apr 11, 2018

@AndyScherzinger @tobiasKaminsky fixed for real this time. Please rebase and test. Thanks!!!

@nextcloud nextcloud deleted a comment Apr 11, 2018
@AndyScherzinger
Copy link
Member

Can't test right now (time-wise) but did the rebase :)

@nextcloud nextcloud deleted a comment Apr 11, 2018
@nextcloud nextcloud deleted a comment Apr 11, 2018
@tobiasKaminsky tobiasKaminsky mentioned this pull request Apr 13, 2018
6 tasks
@mario
Copy link
Contributor Author

mario commented Apr 22, 2018

Anyone tested this?

@nextcloud nextcloud deleted a comment Apr 22, 2018
@nextcloud nextcloud deleted a comment Jul 12, 2018
@nextcloud-android-bot
Copy link
Collaborator

Lint

This 95 warnings
Master 95 warnings

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings166
Experimental Warnings4
Internationalization Warnings12
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings159
Security Warnings163
Dodgy code Warnings207
Total764

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings166
Experimental Warnings4
Internationalization Warnings12
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings158
Security Warnings163
Dodgy code Warnings209
Total765

@nextcloud nextcloud deleted a comment Jul 12, 2018
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jul 13, 2018

👍

Approved with PullApprove

@tobiasKaminsky tobiasKaminsky merged commit 7e5ee95 into master Jul 13, 2018
@tobiasKaminsky tobiasKaminsky deleted the new-media-detection branch July 13, 2018 06:30
@jasonbayton
Copy link
Member

Oh this is exciting! Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants