-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix double search #2490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double search #2490
Conversation
|
Will this then still work for display rotation and search since I'd guess that it is why it has been added back then? Cc @mario |
|
Yes, I tried this
always I had the two favorite results. As explained above, adding it to onViewStateRestored() was the right fix for rotation and such, but then we missed removing it from the other function. |
|
So without having the time to test the branch by search I meant if I do a search within "all files" it'll still work? |
|
Hm. Search is indeed behaving a bit weird. but app returns on search for "2.txt":
--> I will have look into it again. |
|
Hm. After a clean installation I cannot reproduce the problem. So, from my side this is ready for review. |
|
@mario for second review :) |
fa978c7 to
b476269
Compare
f65145c to
4202308
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
4202308 to
378626c
Compare
Adding proposed fix by @AndyScherzinger (#1704 (comment))
Fixes #1908
Fixes #1704
Fixes #2015
Fixes #1698
Fixes #2100
Fixes #2198
onViewStateRestored()is executed directly afteronActivityCreated()when starting the app / switching to e.g. favorite search from "all files".But after previewing a file from favorite search, only
onViewStateRestored()is called, therefore we need to keep it there and thus remove it inonActivityCreated().Signed-off-by: tobiasKaminsky tobias@kaminsky.me