Backport mail share creation #2724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> # Conflicts: # build.gradle
# Conflicts: # src/main/java/com/owncloud/android/ui/fragment/util/SharingMenuHelper.java
24 tasks
Member
Author
|
@tobiasKaminsky Tried close/reopen but for some reason DroneCI doesn't detect this PR and thus doesn't trigger a build :( |
Member
|
I re-checked every settings and they seem ok, @MorrisJobke? |
Member
|
The CI job itself ran fine: https://drone.nextcloud.com/nextcloud/android/5122 Let me retrigger it on CI - the status will update once it's done. |
tobiasKaminsky
force-pushed
the
backportMailShareCreation
branch
from
064c294 to
3b7ca9e
Compare
Codecov Report
@@ Coverage Diff @@
## stable-3.2.x #2724 +/- ##
===============================================
+ Coverage 6.53% 6.54% +0.01%
===============================================
Files 283 283
Lines 28861 28861
Branches 4199 4202 +3
===============================================
+ Hits 1885 1888 +3
+ Misses 26691 26689 -2
+ Partials 285 284 -1
|
Member
|
I removed "backport-request" as this label is for those PRs, that need to be backported. |
AndyScherzinger
requested review from
mario and
tobiasKaminsky
and removed request for
mario
Contributor
|
👍 |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2700 (create an email share)
Backport tested sucessfully
cc @tobiasKaminsky @mario for review