Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Fix #2721

  • show correct drawer icon
  • do not start preferences on "back"

Steps to test:

  • open up privacy, go back
  • open up an external site in drawer

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #2727 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2727      +/-   ##
=========================================
- Coverage    6.48%   6.47%   -0.01%     
=========================================
  Files         289     289              
  Lines       29120   29121       +1     
  Branches     4236    4237       +1     
=========================================
- Hits         1888    1887       -1     
- Misses      26948   26949       +1     
- Partials      284     285       +1
Impacted Files Coverage Δ
...cloud/android/ui/activity/ExternalSiteWebView.java 0% <0%> (ø) ⬆️
.../third_parties/daveKoeller/AlphanumComparator.java 80.45% <0%> (-1.15%) ⬇️

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 20, 2018

👍

Approved with PullApprove

- do not start preferences on "back"

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger AndyScherzinger force-pushed the fixPrivacyExternalView branch from a54e1b8 to 403b702 Compare June 21, 2018 08:42
@mario
Copy link
Contributor

mario commented Jun 21, 2018

👍

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants