Display copy icon and adding send action to the link menu

[AndyScherzinger]

Fix #2705

Beware that I changed the behavior a bit as-in copy to clipboard is now a Toast, not a Snackbar. I checked the behavior for the Android OS and typical (Google) apps and they all show a Toast for this.

@jancborchardt I did change the layout a bit (see screenshots) since aligning the copy icon next to the 3-dot menu seemed strange since shared folders also have the "edit option" for link-share so I thought it be better to add a small copy-icon-badge to the text to indicate it can be clicked and moved the "send link" functionality to the link's menu (see screenshot). Is this fine with you?

Also @tobiasKaminsky @mario please review ❤️

Furthermore I think this should be put into 3.2.1 so I vote to have a backport 🎉

[codecov]

Codecov Report

Merging #2730 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2730      +/-   ##
=========================================
+ Coverage    6.49%   6.49%   +<.01%     
=========================================
  Files         287     288       +1     
  Lines       29058   29070      +12     
  Branches     4234    4235       +1     
=========================================
+ Hits         1888    1889       +1     
- Misses      26886   26897      +11     
  Partials      284     284

Impacted Files	Coverage Δ
...java/com/owncloud/android/utils/ClipboardUtil.java	0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	0% <0%> (ø)	⬆️
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	⬆️
...d/android/ui/activity/CopyToClipboardActivity.java	0% <0%> (ø)	⬆️
.../third_parties/daveKoeller/AlphanumComparator.java	82.75% <0%> (+1.14%)	⬆️

[mario]

👍
Minor codacy stuff.

[AndyScherzinger]

Thanks @mario ❤️ Just pushed the fix for codacy :)

[tobiasKaminsky]

Please fix the typo, though it is not by you ;-)

[tobiasKaminsky]

👍
If "share link" is clickable, the copy icon is, for me, a bit too narrow to it.

[AndyScherzinger]

Will fix typo and whitespace later today :)

Thank you all for the feedback and review 👍

[jancborchardt]

Looks good! I would also only have the feedback of the copy icon needing more whitespace around :)

[AndyScherzinger]

@jancborchardt @tobiasKaminsky like this?

[jancborchardt]

Looks quite similar to the first screenshot it seems. The icon needs to be moved a bit down (verticaly centered with the checkboxes and text) and a bit more to the right.

[AndyScherzinger]

Ah, got it. I always tried to have it as some kind of a badge while you folks want it to me more like a menu icon (size, whitespace, etc.):

[jancborchardt]

Yesss, perfect! :)