-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Revert local search #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert local search #2735
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2735 +/- ##
=========================================
- Coverage 6.48% 6.48% -0.01%
=========================================
Files 289 289
Lines 29120 29133 +13
Branches 4236 4239 +3
=========================================
Hits 1888 1888
- Misses 26948 26961 +13
Partials 284 284
|
|
I found a UI glitch, just when being the default folder after click "upload a file", filter the list for e.g. a single entry: The Fab button jumps to the top, remove the search/filter - Fab stays at the top |
|
@AndyScherzinger thanks for noticing. |
|
Another minor issue, the behavior of the back arrow action bar button differs from the one in the remote file list.
|
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
066911f to
6c69e4e
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
when closing local search, all files are now shown, with correct checked files
some minor code enhancements