Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

  • when closing local search, all files are now shown, with correct checked files

    • click "upload a file"
    • filter the directory
    • close search
    • see all files agian
  • some minor code enhancements

    • add annotations, needed also to be done in base methods
    • comment formatting
    • typo

@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #2735 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2735      +/-   ##
=========================================
- Coverage    6.48%   6.48%   -0.01%     
=========================================
  Files         289     289              
  Lines       29120   29133      +13     
  Branches     4236    4239       +3     
=========================================
  Hits         1888    1888              
- Misses      26948   26961      +13     
  Partials      284     284
Impacted Files Coverage Δ
...cloud/android/ui/adapter/LocalFileListAdapter.java 0% <ø> (ø) ⬆️
...oud/android/ui/fragment/LocalFileListFragment.java 0% <ø> (ø) ⬆️
...ncloud/android/ui/fragment/OCFileListFragment.java 0% <ø> (ø) ⬆️
...loud/android/ui/fragment/ExtendedListFragment.java 0% <0%> (ø) ⬆️
...cloud/android/ui/activity/UploadFilesActivity.java 0% <0%> (ø) ⬆️

@AndyScherzinger
Copy link
Member

I found a UI glitch, just when being the default folder after click "upload a file", filter the list for e.g. a single entry: The Fab button jumps to the top, remove the search/filter - Fab stays at the top

@tobiasKaminsky
Copy link
Member Author

@AndyScherzinger thanks for noticing.
I fixed it :-)

@AndyScherzinger
Copy link
Member

Another minor issue, the behavior of the back arrow action bar button differs from the one in the remote file list.

  • Remote: search active, click back arrow: search closes
  • local/upload chooser: search active, click back arrow: search/filter still active and open, browsing up into parent folder

tobiasKaminsky and others added 4 commits June 21, 2018 10:43
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@mario
Copy link
Contributor

mario commented Jun 21, 2018

👍

Approved with PullApprove

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 21, 2018

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit 8f6a2d1 into master Jun 21, 2018
@AndyScherzinger AndyScherzinger deleted the revertLocalSearch branch June 21, 2018 13:35
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.3.0 milestone Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants