Avatar generation does not need storageManager

[tobiasKaminsky]

Found via google play console:

• have many files downloaded (so account removal takes a while)
• remove account
• see app sometimes crashing as storageManager is null

--> we do not need it at all, therefore removing it

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[nextcloud-android-bot]

Lint

96 warnings

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	158
Security Warnings	163
Dodgy code Warnings	209
Total	765

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	158
Security Warnings	163
Dodgy code Warnings	209
Total	765

[codecov]

Codecov Report

Merging #2775 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2775      +/-   ##
=========================================
+ Coverage    6.37%   6.38%   +<.01%     
=========================================
  Files         294     294              
  Lines       29563   29555       -8     
  Branches     4268    4267       -1     
=========================================
+ Hits         1885    1886       +1     
+ Misses      27389   27380       -9     
  Partials      289     289

Impacted Files	Coverage Δ
...m/owncloud/android/ui/activity/DrawerActivity.java	0% <ø> (ø)	⬆️
...owncloud/android/ui/activity/UserInfoActivity.java	0% <ø> (ø)	⬆️
...wncloud/android/ui/adapter/AccountListAdapter.java	0% <0%> (ø)	⬆️
...loud/android/datamodel/ThumbnailsCacheManager.java	13.56% <0%> (+0.05%)	⬆️
.../java/com/owncloud/android/utils/DisplayUtils.java	5.72% <0%> (ø)	⬆️
...m/owncloud/android/ui/adapter/UserListAdapter.java	0% <0%> (ø)	⬆️
.../third_parties/daveKoeller/AlphanumComparator.java	82.75% <0%> (+1.14%)	⬆️

[AndyScherzinger]

👍

[mario]

👍