Material design revamp

[AndyScherzinger]

Move to new Android X implementation and thus upgrade to latest material design theming.

DONE

• Use sentence case for button labels
• Use primary color for status bar too (instead of primary dark color), like refresh Google apps do too
• replace accent color with primary color
• use new outlined style for secondary buttons and for textfields, use pill style buttons.

Screenshot on Android 9

[tobiasKaminsky]

Where is this crashing? Then i can try to fix it.
A first smoke test did not lead to major crashes.

[AndyScherzinger]

@tobiasKaminsky I did an additional commit which introduced the usage of the bridge theme which prevents the crashes and allow for mixed UI elements ;)

[tobiasKaminsky]

Rebased!

[AndyScherzinger]

@jancborchardt please see the comment by @tobiasKaminsky regarding the buttons on the login screen. ❤️

[github-tomster]

hey a revamp, how about a theme switch?
light/dark and maybe AMOLED compatible BLACK theme?
saves battery (the black amoled only) and this brings a better user experience.
if there is no way to make a black theme maybe only a dark theme at last.
so the user can switch theme in this application too. like in many apps around the www.
see:
https://github.com/stefan-niedermann/nextcloud-notes
there is an theme switch. users like it.

[AndyScherzinger]

Hi @github-tomster thanks for the feedback. Dark theme is out of scope for this PR but is in discussion in another issue. The short version: it's on our radar and will come in the future, the long version: it'll take a while to be done since it is a bit more complicated than with the mentioned app. This client (files app) already implemented dynamic theming based on the server side theme so we do calculate some colors already based on a base/primary color from the server and for a dark theme these calculations will have to work a bit different plus with the server probably having proper dark theme support in the future we will have to support that too in a proper way.

So again: it'll come but might take a while due to limited time. If you or anybody else is willing to step up and implement it, please, feel free and be sure we will support you wherever we can to get it done.

If nobody steps up I'll probably implement it but won't have the time to start working on it before February or March... Busy day job...

[jancborchardt]

@AndyScherzinger @tobiasKaminsky right, the primary button needs to be a bit adjusted to work on the blue (same-colored) background. Can we use a border? Quick mockup based on the web interface log in screen:

@github-tomster the dark theme is tracked at #2188 and being worked on by awesome community member @dan0xii. :)

[AndyScherzinger]

Sure thing... need to have to separate style implemented here since the second button would be an outlined one then (like the new secondary action buttons) 👍
Arrow is probably not on the button, but maybe possible.

[jancborchardt]

Yeah, nevermind the arrow – it’s just how it is on the server. :)

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	83	83
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	157
Internationalization Warnings	15
Malicious code vulnerability Warnings	12
Multithreaded correctness Warnings	9
Performance Warnings	118
Security Warnings	66
Dodgy code Warnings	135
Total	547

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	158
Internationalization Warnings	15
Malicious code vulnerability Warnings	12
Multithreaded correctness Warnings	9
Performance Warnings	118
Security Warnings	66
Dodgy code Warnings	135
Total	548

[tobiasKaminsky]

🎉 cool to have this in