Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Implementation of nextcloud/server#11898
Needs nextcloud/android-library#196

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

tobiasKaminsky and others added 2 commits November 7, 2018 21:57
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings9595
Errors

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings163
Internationalization Warnings14
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings121
Security Warnings202
Dodgy code Warnings137
Total691

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings163
Internationalization Warnings14
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings121
Security Warnings202
Dodgy code Warnings137
Total691

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 7, 2018

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit 93bc0b4 into master Nov 7, 2018
@AndyScherzinger AndyScherzinger deleted the hideDownload branch November 7, 2018 21:14
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.4.0 milestone Nov 7, 2018
@nextcloud nextcloud deleted a comment Nov 7, 2018
@tobiasKaminsky
Copy link
Member Author

Do you have an idea what happened to Codacy? This is not shown in "checks passed" for the last PRs?

@AndyScherzinger
Copy link
Member

no odea really for some reaason Codacy seems to not detect quite a lot of PRs / changed PRs during the last days. Quite strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants