Video thumbnail #36
Video thumbnail #36
Conversation
removed empty image parts
|
Nice! :) But does this mean that every single person needs to add this config option to their config? Can’t we enable that by default? cc @LukasReschke |
|
@jancborchardt you need to activate this in your server, but this patch is needed to even be able to see videothumbs in the android app +1 |
| registerLongClickListener(); | ||
| } else { | ||
| switchToListView(); | ||
| // switchToGridView(); |
|
@jancborchardt not every user, but every admin. |
| int x3 = 0; | ||
| int y3 = 0; | ||
|
|
||
| double ym = ( ((Math.pow(x3,2) - Math.pow(x1,2) + Math.pow(y3,2) - Math.pow(y1,2)) * |
There was a problem hiding this comment.
a lot of zeros in the calculations so this probably can be simplified ;)
There was a problem hiding this comment.
I doubt so, as this is a mainly pythagoras and he needs three coordinates.
To simplify it, I have chosen them to be mostly zero.
@tobiasKaminsky yeah, this is still a bit bad cause this results in different UX for different people depending on the server, and this should ideally not happen. Since it’s a security issue, is it possible to generate the previews client-side as well? |
|
@jancborchardt when the previews are generated in a sandbox the generation of videos can be enabled by default. |
|
@jancborchardt as far as I recall we do, yes. |
|
@AndyScherzinger can you make video thumbnails for me? |
|
@tobiasKaminsky absolutely, do you need an icon which is shown when there is no thumbnail or a "play icon" overlay which is put on top of a video thumbnail? (can do both, whatever you need 😄) |
|
Placeholder when there is no video based thumbnail available. |
|
Erm... It is all in place :D |
|
These are already in use for all videos atm since we didn't have video thumbnails yet. :) |
|
You are right, then we are done here |
|
@tobiasKaminsky can you rebase and resolve the conflicts? I can also give it a try but I guess it is saver when you do it since it is your PR. I'll test drive it afterwards. Code changes look good to me so far :) |
|
The placeholders work fine for me, the real video thumbnails need to be checked by someone else :(
|
|
This is already working :) |
|
Works, see screenshot. But only if the server already created the thumbnail. At first I didn't log into the web view and opened the folder which seems to trigger the thumbnail generation. After I did that the Android client was able to fetch the thumbnails. Before that you receive a
|
|
|
|
@przybylski do you have the time to do a review? I already did one :) |
|
@AndyScherzinger I already did a review some time ago, if nothing changed since than 👍 |
|
Sorry @przybylski I missed that :( @tobiasKaminsky can you update it to latest master for another test round before merging? |
|
@AndyScherzinger is updated |
|
Sweet, will do a test tomorrow or beginning of next week. |
|
Test successful, can imho be merged. 👍 |
|
LGTM is broken again... grrr |
|
👍 |
5 participants
Enable video thumbnail.
Needed:
'enabledPreviewProviders' => array(
'OC\Preview\Movie'
)
in config.php
@jancborchardt we need a video thumbnail.