Conversation
|
Checked the code LGTM 👍 |
| mAccount = account; | ||
| } | ||
|
|
||
| public ThumbnailGenerationTask(FileDataStorageManager storageManager, Account account){ |
There was a problem hiding this comment.
you might wanna have a look on NonNull annotation in android :)
There was a problem hiding this comment.
Denotes that a parameter, field or method return value can never be null.
But it is the other way, the parameter should never be null, but it can.
There was a problem hiding this comment.
So handling null parameter via throwing exception seems a bit odd
There was a problem hiding this comment.
It is adapted from ownCloud ;)
This should not happen as far as I have seen the code, so I would leave it this way.
|
👍 |
|
👍 |
AndyScherzinger
force-pushed
the
thumbnailDuringUpload
branch
from
dea553e to
5ad7225
Compare
|
Please review again. |
| } | ||
|
|
||
| mFile = params[0]; | ||
| if (params.length == 2){ |
There was a problem hiding this comment.
This is wrong on so many levels... but i'll let it slide since it is adopted from ownCloud
There was a problem hiding this comment.
As I am always eager to learn/code better, please help me and show a better solution.
First I wanted to create a new inner class that holds both values and can be passed to the task. But it was too much work ;-)
There was a problem hiding this comment.
So, to be merged to master or wait for @przybylski's coding ninja skills?
There was a problem hiding this comment.
Sweet! Always a pleasure pushing things forward with you guys! 💯
|
👍 |
|
Code LGTM - unfortunately I can't test it right now since instant upload is broken for Android N |
|
LGTM |
|
Merged 🚀 |
3 participants
No description provided.