Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #4592

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11078.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.8PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

SpotBugs (stable-3.8)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #4595 into stable-3.8 will decrease coverage by 0.02%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             stable-3.8    #4595      +/-   ##
================================================
- Coverage         16.99%   16.97%   -0.03%     
  Complexity            1        1              
================================================
  Files               361      361              
  Lines             32000    32133     +133     
  Branches           4511     4546      +35     
================================================
+ Hits               5438     5454      +16     
- Misses            25659    25778     +119     
+ Partials            903      901       -2
Impacted Files Coverage Δ Complexity Δ
...cloud/android/ui/helpers/FileOperationsHelper.java 2.39% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/preview/PreviewMediaFragment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java 29.63% <0%> (+0.19%) 0% <0%> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 19.96% <0%> (+0.23%) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 35.76% <0%> (+0.72%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 83.33% <0%> (+1.19%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 24.89% <0%> (+1.26%) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 51.57% <0%> (+1.57%) 0% <0%> (ø) ⬇️

@AndyScherzinger AndyScherzinger merged commit 8e3ae4f into stable-3.8 Oct 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/4592/stable-3.8 branch October 2, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants