Fix vanishing images #4647
Merged
Fix vanishing images #4647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a parent, nor a fileId as the are only virtual files upon refreshing folder - they were found in database, but only updated with fileId=-1. - they were not found in parent folder, so we have to search them manually via file path Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Member
Author
|
/backport to stable-3.8 |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11191.apk |
Collaborator
Codacy275Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #4647 +/- ##
=========================================
Coverage ? 17.27%
Complexity ? 3
=========================================
Files ? 373
Lines ? 32124
Branches ? 4556
=========================================
Hits ? 5548
Misses ? 25675
Partials ? 901
|
AndyScherzinger
approved these changes
Oct 10, 2019
|
backport to stable-3.8 in #4651 |
tobiasKaminsky
added a commit
that referenced
this pull request
Oct 11, 2019
bfacbee Merge pull request #4630 from nextcloud/releaseProcess fe07963 add imfo about hotfix and security fix releases f1cf050 Merge pull request #4626 from nextcloud/removeCustomEdit af7bf9b Merge pull request #4647 from nextcloud/fixVanishingImages 4a9c7c8 Merge pull request #4648 from nextcloud/fixRelativePath a2f2da9 move logic completely into function prevent double subfolders 73fc5e4 OCFiles can be retrieved also by photo search, which then do not have a parent, nor a fileId as the are only virtual files upon refreshing folder - they were found in database, but only updated with fileId=-1. - they were not found in parent folder, so we have to search them manually via file path cf74da7 - remove CustomEditTextField - do not use fancy material header for textInput, but regular TextView - do not show QR button on legacy login - fix layout in tablet mode 3e44472 daily dev 20191010
This was referenced Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4502
OCFiles can be retrieved also by photo search, which then do not have a parent, nor a fileId as the are only virtual files
upon refreshing folder
Signed-off-by: tobiasKaminsky tobias@kaminsky.me