Dark theme: color enhancements

[tobiasKaminsky]

• overwrite in values-night/colors only values that differ
• move branding colors back to setup.xml

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[AndyScherzinger]

@tobiasKaminsky changes look good to me. Other than that a question: would you be fine with some renamings here? (I'd open an issue of course and then a PR; not sure when but looking through the colors there is some room for improvement regarding names naming pattern).

[tobiasKaminsky]

Yeah, of course, just open up an issue :-)

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11467.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

304

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423

[codecov]

Codecov Report

Merging #4762 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #4762     +/-   ##
===========================================
- Coverage     17.97%   17.48%   -0.5%     
  Complexity        3        3             
===========================================
  Files           376      376             
  Lines         32383    32383             
  Branches       4568     4568             
===========================================
- Hits           5822     5663    -159     
- Misses        25596    25801    +205     
+ Partials        965      919     -46

Impacted Files	Coverage Δ	Complexity Δ
...ava/com/owncloud/android/files/FileMenuFilter.java	0% <0%> (-52.06%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	79.76% <0%> (-3.58%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	29% <0%> (-3.06%)	0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java	25.3% <0%> (-2.44%)	0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java	50% <0%> (-1.58%)	0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java	23.62% <0%> (-1.27%)	0% <0%> (ø)
...loud/android/datamodel/FileDataStorageManager.java	36.54% <0%> (-0.72%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	35.58% <0%> (-0.19%)	0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java	22.79% <0%> (ø)	0% <0%> (ø)	⬇️
...xtcloud/client/account/UserAccountManagerImpl.java	50% <0%> (ø)	0% <0%> (ø)	⬇️
... and 3 more