consistently use snake_case for color resources

[AndyScherzinger]

Resolves #4767

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11469.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

303

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	69
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	44
Dodgy code Warnings	138
Total	423

[codecov]

Codecov Report

Merging #4768 into master will decrease coverage by 0.07%.
The diff coverage is 20%.

@@             Coverage Diff              @@
##             master    #4768      +/-   ##
============================================
- Coverage     17.55%   17.48%   -0.08%     
  Complexity        3        3              
============================================
  Files           376      376              
  Lines         32383    32383              
  Branches       4568     4568              
============================================
- Hits           5685     5662      -23     
- Misses        25780    25801      +21     
- Partials        918      920       +2

Impacted Files	Coverage Δ	Complexity Δ
...ncloud/android/ui/adapter/ActivityListAdapter.java	3.63% <0%> (ø)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java	51.57% <0%> (ø)	0 <0> (ø)	⬇️
...ndroid/ui/activity/SsoGrantPermissionActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ud/android/ui/adapter/NotificationListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...m/owncloud/android/ui/activity/DrawerActivity.java	45.19% <100%> (ø)	0 <0> (ø)	⬇️
.../owncloud/android/ui/activity/ToolbarActivity.java	60.86% <0%> (-2.9%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	33.39% <0%> (-2.74%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	80.95% <0%> (-1.2%)	0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	20.01% <0%> (-0.25%)	0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java	29.77% <0%> (-0.2%)	0% <0%> (ø)
... and 2 more