Skip to content

Conversation

@Kilian-Perisset
Copy link
Member

Fixing issue #4764
To allow using of set as in picture properties

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #4795 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4795      +/-   ##
============================================
+ Coverage     17.48%   17.51%   +0.02%     
  Complexity        3        3              
============================================
  Files           376      376              
  Lines         32385    32387       +2     
  Branches       4569     4569              
============================================
+ Hits           5661     5671      +10     
+ Misses        25813    25798      -15     
- Partials        911      918       +7
Impacted Files Coverage Δ Complexity Δ
...ncloud/android/ui/fragment/FileDetailFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 35.03% <0%> (-0.55%) 0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.57% <0%> (-0.41%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 19.93% <0%> (-0.25%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 29.58% <0%> (-0.2%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 22.79% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 51.57% <0%> (+1.96%) 0% <0%> (ø) ⬇️
...m/owncloud/android/ui/activity/DrawerActivity.java 45.19% <0%> (+2.29%) 0% <0%> (ø) ⬇️

@ezaquarii
Copy link
Collaborator

@Shagequi please check CI report.

@AndyScherzinger
Copy link
Member

CI looks good, the DCO is missing though.

Kilian Périsset added 4 commits November 5, 2019 10:21
Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
…Infomaniak/android-infomaniak-drive into feature/resolve-picture-set-bug

* 'feature/resolve-picture-set-bug' of https://github.com/Infomaniak/android-infomaniak-drive:
  Applied ability to set as wallpaper from properties of a picture
…Infomaniak/android-infomaniak-drive into feature/resolve-picture-set-bug

* 'feature/resolve-picture-set-bug' of https://github.com/Infomaniak/android-infomaniak-drive:
  Applied ability to set as wallpaper from properties of a picture

Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
@Kilian-Perisset Kilian-Perisset changed the title Fix of Issue #4764 Fixing picture set as wallpaper issue in properties Nov 5, 2019
@Kilian-Perisset Kilian-Perisset changed the title Fixing picture set as wallpaper issue in properties Fixing picture "set as wallpaper" issue in properties Nov 5, 2019
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11546.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

304

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@Kilian-Perisset
Copy link
Member Author

Re-created on : #4801

@Kilian-Perisset Kilian-Perisset deleted the feature/resolve-picture-set-bug branch November 5, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants