Skip to content

Conversation

@dan0xii
Copy link
Contributor

@dan0xii dan0xii commented Nov 4, 2019

Fixes #4783.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11530.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

304

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #4796 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4796      +/-   ##
============================================
+ Coverage     17.48%   17.49%   +0.01%     
  Complexity        3        3              
============================================
  Files           376      376              
  Lines         32385    32385              
  Branches       4569     4569              
============================================
+ Hits           5661     5666       +5     
+ Misses        25813    25800      -13     
- Partials        911      919       +8
Impacted Files Coverage Δ Complexity Δ
.../ui/dialog/ExpirationDatePickerDialogFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/com/owncloud/android/ui/SquareLinearLayout.java 0% <0%> (-50%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 29% <0%> (-0.77%) 0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.3% <0%> (-0.68%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 22.22% <0%> (-0.57%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.17% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 51.57% <0%> (+1.96%) 0% <0%> (ø) ⬇️
...m/owncloud/android/ui/activity/DrawerActivity.java 45.19% <0%> (+2.29%) 0% <0%> (ø) ⬇️

@tobiasKaminsky tobiasKaminsky merged commit d208681 into master Nov 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the datepicker branch November 5, 2019 19:10
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Nov 5, 2019
tobiasKaminsky added a commit that referenced this pull request Nov 6, 2019
9e15f5e Merge pull request #4799 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.5.2
d208681 Merge pull request #4796 from nextcloud/datepicker
7a8aee3 [tx-robot] updated from transifex
a3ae321 Bump gradle from 3.5.1 to 3.5.2
b0563b9 Theming: Fix date picker button text colour
207f894 [tx-robot] updated from transifex
1ec0984 [tx-robot] updated from transifex
5131514 [tx-robot] updated from transifex
38a83bb daily dev 20191102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No buttons on date picker

5 participants