Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #4801

Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.9PR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (stable-3.9)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11569.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.9PR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (stable-3.9)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #4803 into stable-3.9 will increase coverage by 0.02%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             stable-3.9    #4803      +/-   ##
================================================
+ Coverage         17.41%   17.43%   +0.02%     
  Complexity            3        3              
================================================
  Files               376      376              
  Lines             32309    32311       +2     
  Branches           4560     4560              
================================================
+ Hits               5626     5634       +8     
  Misses            25770    25770              
+ Partials            913      907       -6
Impacted Files Coverage Δ Complexity Δ
...ncloud/android/ui/fragment/FileDetailFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 50% <0%> (-1.58%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 23.62% <0%> (-1.27%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 35.58% <0%> (-0.19%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.17% <0%> (+0.08%) 0% <0%> (ø) ⬇️
...owncloud/android/ui/activity/SettingsActivity.java 38.52% <0%> (+0.19%) 0% <0%> (ø) ⬇️
...ncloud/android/ui/fragment/OCFileListFragment.java 25.57% <0%> (+0.27%) 0% <0%> (ø) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 23.36% <0%> (+0.56%) 0% <0%> (ø) ⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java 29.77% <0%> (+0.76%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 83.33% <0%> (+2.38%) 0% <0%> (ø) ⬇️
... and 1 more

@AndyScherzinger AndyScherzinger merged commit c80ca1a into stable-3.9 Nov 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/4801/stable-3.9 branch November 7, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants