Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 25, 2019

Bumps flexbox from 1.1.1 to 2.0.0.

Release notes

Sourced from flexbox's releases.

2.0.0

Performance improvements by avoiding child views are measured more than twice #46

The version 2.0.0 improves the performance significantly especially FlexboxLayout is deeply nested.
As described in #514, there were unnecessary measure calls even if any Flexitems in a FlexLine didn't have any flexGrow or flexShrink attributes set.
Similarly, the default values for alignItems and alignContent for FlexboxLayout has changed from stretch to flex_start starting from 2.0.0 because setting stretch for alignItems turned out to be expensive. Setting the default value as stretch might increase the unnecessary measure calls.

This is a major version release because the change may break the existing apps.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @tobiasKaminsky.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [flexbox](https://github.com/google/flexbox-layout) from 1.1.1 to 2.0.0.
- [Release notes](https://github.com/google/flexbox-layout/releases)
- [Commits](google/flexbox-layout@1.1.1...2.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Nov 25, 2019
@tobiasKaminsky
Copy link
Member

Tested and still looks good in file detail sharing 👍

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11770.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

333

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings117
Security Warnings44
Dodgy code Warnings134
Total418

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings117
Security Warnings44
Dodgy code Warnings134
Total418

@AndyScherzinger AndyScherzinger merged commit aa43181 into master Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the dependabot/gradle/com.google.android-flexbox-2.0.0 branch November 27, 2019 22:36
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Nov 27, 2019
tobiasKaminsky added a commit that referenced this pull request Nov 29, 2019
2c57e37 Merge pull request #4784 from nextcloud/hideAutoUploadEntries
5257fb2 [tx-robot] updated from transifex
aa43181 Merge pull request #4882 from nextcloud/dependabot/gradle/com.google.android-flexbox-2.0.0
1f4e857 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
d17c853 re-add button/action and improve upon code review
74bfe47 remove action button, use checkable menu item for shown/hidden state display
3e872df add more spotbug exclusions (for 3rd party libs)
4e0b405 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
7c62ad6 unify use of boolean, make use of lombok getter/setters, remove unneeded boolean boxing
bedc2b4 housekeeping, removing unused resources
ca6918f show/hide improvements when list is completed hidden + nicer empty UI + action button
23e4424 show/hide auto upload list items
540c649 Merge pull request #4894 from nextcloud/dependabot/gradle/kotlin_version-1.3.61
f34ba2c Bump kotlin_version from 1.3.60 to 1.3.61
48038d5 Merge pull request #4883 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.2.0
83e0ebc [tx-robot] updated from transifex
21c0de3 daily dev 20191127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants