Disable android backup on the QA app #4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
tobiasKaminsky
approved these changes
Nov 25, 2019
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Codecov Report
@@ Coverage Diff @@
## master #4885 +/- ##
============================================
+ Coverage 17.62% 17.65% +0.02%
Complexity 3 3
============================================
Files 383 383
Lines 32509 32509
Branches 4587 4587
============================================
+ Hits 5731 5740 +9
Misses 25857 25857
+ Partials 921 912 -9
|
Member
|
I just disabled one lint check. Thanks for the fix and the idea! |
Contributor
Author
|
No problem! |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11744.apk |
Collaborator
Codacy312Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
Nov 26, 2019
Member
|
All checks ✅ merging... ❤️ Thanks for the fix @ArisuOngaku 🥇 |
tobiasKaminsky
added a commit
that referenced
this pull request
Nov 27, 2019
e92daa2 Merge pull request #4853 from nextcloud/migrate-simple-cases-of-get-current-account-to-get-user 99d9a69 Merge pull request #4885 from nextcloud/disable_android_backup_qa 10960bf [tx-robot] updated from transifex 9f24b25 [tx-robot] updated from transifex b7876c4 disable GoogleAppIndexingWarning lint check 11687c6 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 80fb800 Merge commit 'a7eb7148fa0ceb42981366eb2ddcf0ff921e6a55' b91136c Disable android backup on the QA app a7eb714 Migrate simple cases of getCurrentAccount() to getUser() 6249a06 daily dev 20191123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, there are multiple versions of the QA app that share the same database versions for different migrations. When the android backup feature is enabled by the user's devices, this leads to invalidly restored database state and then crashes that would normally not happen in production.
This PR simply disables the android backup feature for the QA version of the app.
(as seen in #4788)