Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 3, 2019

fix #4750
fix #4751
fix #4755
fix #4756

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky changed the title fix wrong text color on search input on dark mode fix wrong text color on edit text input on dark mode Dec 3, 2019
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11820.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

333

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #4923 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4923      +/-   ##
============================================
- Coverage     17.72%   17.72%   -0.01%     
  Complexity        3        3              
============================================
  Files           384      384              
  Lines         32650    32654       +4     
  Branches       4597     4598       +1     
============================================
- Hits           5788     5787       -1     
- Misses        25938    25942       +4     
- Partials        924      925       +1
Impacted Files Coverage Δ Complexity Δ
...in/java/com/owncloud/android/utils/ThemeUtils.java 50.77% <0%> (-0.8%) 0 <0> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (-1.2%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.01% <0%> (-0.09%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 57.39% <0%> (+0.43%) 0% <0%> (ø) ⬇️

@AndyScherzinger AndyScherzinger merged commit d006ac2 into master Dec 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the theming_sharing_box branch December 5, 2019 10:20
@AndyScherzinger
Copy link
Member

Works like a charm 👍

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 5, 2019
tobiasKaminsky added a commit that referenced this pull request Dec 6, 2019
645f194 Merge pull request #4950 from nextcloud/changelog-master-stable-3.9.2
d006ac2 Merge pull request #4923 from nextcloud/theming_sharing_box
1f861df Add changelog for 3.9.2
eb74b52 Merge pull request #4947 from nextcloud/fixTime
1584de9 use SystemClock.elapsedRealtime() everywhere
664727b Merge pull request #4945 from nextcloud/dependabot/gradle/com.pinterest-ktlint-0.36.0
ead35eb [tx-robot] updated from transifex
1791403 daily dev 20191205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants